Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
The JIRA issue is here: https://issues.apache.org/jira/browse/ROCKETMQ-174
And I have added a time tracker for this issue.
---
If your project is set up for it, you can reply to this
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111319070
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
If the change is non-t
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/90
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Overall looks good to me. Nice job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user vesense commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111317677
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
If the change is non-tri
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/77
Sorry to response for this PR. It seems good ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
@shroman @lizhanhui What's your opinion about this feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@shroman @lizhanhui Could you help us to review this long-time delayed PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
@shroman @zhouxinyu Could you help review this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/89
@shroman @stevenschew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111210164
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11057354)
Coverage increased (+0.03%) to 34.653% when pulling
**b5604b65a269e3b
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11057354)
Coverage increased (+0.03%) to 34.653% when pulling
**b5604b65a269e3b
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11057354)
Coverage increased (+0.03%) to 34.653% when pulling
**b5604b65a269e3b
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/91
[ROCKETMQ-174]Fix spelling errors
This is to fix large number of spelling errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/li
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/85
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67855
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Softwa
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67737
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Softwa
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/89
Comment to bump up this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/78
Guys, any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
> But I don't quite understand why it has to have so many levels -- why not
to remove rmqAddressServerDomain and let the user use only
rocketmq.namesrv.domain ... ?
Yes, I am al
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
@vongosling @shroman any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/88
Merged as this is really trivial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/77
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/28
As far as I know, rocketmq will clean the unexpired files as long as space
is 85% full and cleanFileForciblyEnable=true(true by default)
Please refer to the code snippet
`
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/77
As this PR is pretty trivial, I'll merge it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/28
@Jaskey @vsair No, Broker only delete expired files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
32 matches
Mail list logo
