GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/92
[ROCKETMQ-175] Consumer may miss messages because of inconsistent subâ¦
For push mode, update subscription version when rebalance result changed,
then send heart beat to broker immediately
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/85
[](https://coveralls.io/builds/11083601)
Coverage increased (+2.8%) to 34.628% when pulling
**4449b2b21bc9aa19
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111525174
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.apach
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111524822
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.ap
Hi,
If the goal is to move the project more quickly, adding
maintainers will only hinder the progress not help move faster as
it's another layer of getting a patch committed. Since RocketMQ is
still in the incubation stage, IMO too soon to introduce
maintainers. Once t
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524324
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.apach
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.ap
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211864
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.apach
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211660
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionState.java
---
@@ -19,5 +19,5 @@
public enum LocalTransact
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211195
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/listener/ConsumeReturnType.java
---
@@ -33,7 +33,7 @@
/**
*
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
@zhouxinyu @vesense
for some public class or enum, I don't agree we rename it directly since it
will introduce the compatibility problem for the user who upgrade from the
older version
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11083278)
Coverage increased (+0.0007%) to 34.626% when pulling
**7e07b87f7124d
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11083278)
Coverage increased (+0.0007%) to 34.626% when pulling
**7e07b87f7124d
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
Will look into this PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Hi Bruce,
> Is the RocketMQ code base currently divided up with certain people
working only in certain areas?
Not only, but most of committers have their focus areas.
We don't want to divide the code base totally for certain people, IMO,
global collaboration with a certain focus may be a better
Dear Podling,
As you may be aware, the Incubator has recently selected a new logo. In
conjunction with this new logo, Sally has prepared material to help podlings
incorporate incubator branding into their logos.
Please review the Press Kit for Podlings page at
http://incubator.apache.org/guid
Hi yukon,
I haven't heard of this concept at the ASF before, so I guess it's
something that only a few projects are using. It seems kinda heavy-handed,
but maybe this is just my perspective in not having worked on the RocketMQ
code base. Is the RocketMQ code base currently divided up with certain
+1
I remembered storm pmc member xinwang has raised the similar problem. IMO, we
can learn from Apache other project’s best practice. Maintainer’s introduction
is a good choise for RocketMQ's Issue, codebase and other community affairs.
Consider this is a good start, We could polish this mecha
Hi all,
We have noticed that there are some problems in our PR review process, as
Justin mentioned in the IPMC board report, the slow PR processing speed
will drain contributors' positive energy for continuous contribution, which
will impede healthy development of Apache RocketMQ community.
So we
20 matches
Mail list logo
