[GitHub] incubator-rocketmq pull request #127: [ROCKETMQ-233] Fix pull interval issue

Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/127#discussion_r124174720 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java --- @@ -273,6 +273,17 @@ public void pullM

[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...

Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/128 @evthoriz please update the jira's discriptions so that the user knows this bug and determine whether they should upgrade --- If your project is set up for it, you can reply to this email

Podling Report Reminder - July 2017

Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 19 July 2017, 10:30 am PDT. The report for your podling will form a

Fixed: apache/incubator-rocketmq#650 (develop - a9b66d5)

Build Update for apache/incubator-rocketmq - Build: #650 Status: Fixed Duration: 25 minutes and 13 seconds Commit: a9b66d5 (develop) Author: dongeforever Message: Update current version to V4_2_0_SNAPSHOT View the changeset: https://github.com/apache/incubato

Re: Podling Report Reminder - July 2017

Hi, I have created a new page as before[1], to track the July podling report for Apache RocketMQ. Once we finished it. i sincerely request mentors to review and sign them off :-) [1] https://cwiki.apache.org/confluence/display/ROCKETMQ/Apache+RocketMQ+Board+Reports

[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...

Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/128 @Jaskey From the aspect of client, every batch request would cause printing 2 warning logs. But the further influence is it may damage the performance in high throughput scenario where b

[GitHub] incubator-rocketmq issue #119: [ROCKETMQ-223]-Rename DEFAULT_TOPIC

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/119 All right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-rocketmq issue #119: [ROCKETMQ-223]-Rename DEFAULT_TOPIC

Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/119 @Jaskey Ok, it makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] incubator-rocketmq issue #115: [ROCKETMQ-204]-when all brokers is offline, c...

Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/115 @lizhanhui @vsair @zhouxinyu any opinions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] incubator-rocketmq issue #119: [ROCKETMQ-223]-Rename DEFAULT_TOPIC

Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/119 @lizhanhui . I think we'd better rename the topic name also since it has impact many users that they don't actually know what is this topic and hot to maintain it. In the clien

[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12165746) Coverage increased (+0.02%) to 38.461% when pulling **3b9780c1aa3945

[GitHub] incubator-rocketmq issue #118: [ROCKETMQ-28] Encrypt transmission layer.

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/118 [](https://coveralls.io/builds/12165746) Coverage increased (+0.02%) to 38.461% when pulling **3b9780c1aa3945

[GitHub] incubator-rocketmq issue #119: [ROCKETMQ-223]-Rename DEFAULT_TOPIC

Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/119 Another thing is -- do we need the default topic at all? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124500517 --- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java --- @@ -173,12 +177,20 @@ public void setVipChannelEnabled(final bo

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124500269 --- Diff: remoting/src/main/java/org/apache/rocketmq/remoting/netty/FileRegionEncoder.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to th

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124499117 --- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java --- @@ -173,12 +177,20 @@ public void setVipChannelEnabled(final bo

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124498602 --- Diff: remoting/src/main/java/org/apache/rocketmq/remoting/netty/FileRegionEncoder.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to th

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124494325 --- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java --- @@ -173,12 +177,20 @@ public void setVipChannelEnabled(final bo

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124493428 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/RequestCode.java --- @@ -17,7 +17,9 @@ package org.apache.rocketm

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124492935 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/RequestCode.java --- @@ -17,7 +17,9 @@ package org.apache.rocketm

[GitHub] incubator-rocketmq pull request #118: [ROCKETMQ-28] Encrypt transmission lay...

Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124492297 --- Diff: remoting/src/main/java/org/apache/rocketmq/remoting/netty/FileRegionEncoder.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to th

[GitHub] incubator-rocketmq issue #119: [ROCKETMQ-223]-Rename DEFAULT_TOPIC

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/119 Looks good to me. Actually some of the client code relies on presence of the topic which would log exceptions otherwise. IMO, we'd better rename the variable name only to mainta

[GitHub] incubator-rocketmq issue #119: [ROCKETMQ-223]-Rename DEFAULT_TOPIC

Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/119 @lizhanhui In my option for your consern # 2, I even consider that we separate the configuration logic from the default topic, since the clients may use different default key.