Re: contribute rocketmq client4cpp

Hi, Additional email, sorry for forgetting to paste wangqiwei email. I am very pleased to see your contribution for RocketMQ community, especially for this sustainable c++ sdk. Looking forward to hear from you. As there're more and more dev. activities, you may have to request ICLA[1] for futu

Re: contribute rocketmq client4cpp

Hi Wangqiwei, Very pleased to see your contribution for RocketMQ community, especial for this production sustainable c ++ sdk. Looking forward to your further feedback. With more and more dev. activities, you may request ICLA[1] for more convenient contribution. But now, Let’s move this project

[GitHub] incubator-rocketmq pull request #141: [ROCKETMQ-254] fix logger appender uni...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/141#discussion_r132088233 --- Diff: logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java --- @@ -70,24 +76,28 @@ public static MQProduce

[GitHub] incubator-rocketmq pull request #140: [ROCKETMQ-253]Compress RegisterBrokerB...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/140#discussion_r132087129 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java --- @@ -40,4 +57,114 @@ public void setTopicCon

[GitHub] incubator-rocketmq pull request #140: [ROCKETMQ-253]Compress RegisterBrokerB...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/140#discussion_r132086276 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java --- @@ -148,12 +148,13 @@ private RegisterBrokerResult register

[GitHub] incubator-rocketmq pull request #139: [ROCKETMQ-242] mqclient can not fetch ...

Github user qqeasonchen closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] incubator-rocketmq pull request #139: [ROCKETMQ-242] mqclient can not fetch ...

Github user qqeasonchen commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/139#discussion_r131905325 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java --- @@ -255,19 +255,17 @@ public void start() t

[GitHub] incubator-rocketmq issue #138: [ROCKETMQ-138]add implement SelectMessageQueu...

Github user lyy4j commented on the issue: https://github.com/apache/incubator-rocketmq/pull/138 I agree with you that ConsistentHashRouter has a good enough abstraction， making the code more cleanner and extensible. But I think SelectMessageQueueByConsistentHash will not increas

[GitHub] incubator-rocketmq issue #138: [ROCKETMQ-138]add implement SelectMessageQueu...

Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/138 @lyy4j 1. I will still suggest resuing ConsistentHashRouter since it has a good enough abstraction which will make your selector much cleanner and easier as well as extensible(s

[GitHub] incubator-rocketmq pull request #139: [ROCKETMQ-242] mqclient can not fetch ...

Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/139#discussion_r131043380 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java --- @@ -255,19 +255,17 @@ public void start() throws