Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/126
Thanks @lindzh, i have merged it. Please close this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user qqeasonchen commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132623736
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -225,10 +225,13 @@ public void start() t
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132622123
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -45,19 +47,22 @@ public void init() throws Exception {
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
[](https://coveralls.io/builds/12789603)
Coverage increased (+0.2%) to 38.926% when pulling
**f7b7b5b1d8b7536
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
[](https://coveralls.io/builds/12789603)
Coverage increased (+0.2%) to 38.926% when pulling
**f7b7b5b1d8b7536
Hi All,
I had passed ICLA, Thanks.
At 2017-08-09 14:55:46, "Von Gosling" wrote:
Hi,
Additional email, sorry for forgetting to paste wangqiwei email.
I am very pleased to see your contribution for RocketMQ community, especially
for this sustainable c++ sdk. Looking forward to hear fro
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132427103
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -45,19 +47,22 @@ public void init() throws Excep
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/141
[](https://coveralls.io/builds/12777678)
Coverage decreased (-0.4%) to 38.728% when pulling
**9b5dfd8c0dbbaec
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/143
[](https://coveralls.io/builds/12774632)
Coverage increased (+0.03%) to 38.772% when pulling
**e767801526ef80
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/143
[](https://coveralls.io/builds/12774632)
Coverage increased (+0.03%) to 38.772% when pulling
**e767801526ef80
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
[](https://coveralls.io/builds/12774581)
Coverage decreased (-0.04%) to 38.701% when pulling
**18cb81b21ad6fa
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
[](https://coveralls.io/builds/12774581)
Coverage decreased (-0.04%) to 38.701% when pulling
**18cb81b21ad6fa
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/143
1. "As force delete may cause message lost,how about add a warnning in
command help?"--->Added.
2. "And also add a monitor disk usage tool command for check." --> I do not
follow th
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/141
[](https://coveralls.io/builds/12774185)
Coverage decreased (-0.5%) to 38.622% when pulling
**ee2e2cdb01c3711
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/141
[](https://coveralls.io/builds/12774185)
Coverage decreased (-0.5%) to 38.622% when pulling
**ee2e2cdb01c3711
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@evthoriz we usually need some measure to verify our correction, no matter
what you do. IMO, unit test is a effective practice when we coding. Looking
forward to hear from you again :-
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
Normalize the naming is surely good to have. I'd update the naming soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132393089
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -225,10 +225,13 @@ public void start() throws
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
I created this thread just to address some unit test naming problem. Do we
need normalize here ? naming are various nowadays, IMO, methodTest_condition or
testMethond_condition may be
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/141#discussion_r132391646
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -70,24 +76,28 @@ public static MQProducer
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/126
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
21 matches
Mail list logo
