Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Trying to create a CMakeLists.txt on top of this PR, but it looks there is
something missing:
```cpp
MetaqJson::Value json
```
I grepped MetaqJson in the code,
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
A second issue about alog, there are only header files and binary static
lib file, where is source code for the static lib files?
---
If your project is set up for it, you ca
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
About the disruptor module in src/thread, copyright declarations of this
module files are different. Is the source code copied from somewhere? If so, is
its license compatible
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Many useless files are included, for example in project folder. Can we
remove them?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
As it's now part of the Apache RocketMQ project, IMO, rocketmq namespace
should be used instead of metaq.
---
If your project is set up for it, you can reply to this email and
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r132838531
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -95,14 +95,15 @
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r132838496
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -201,177 +229,143 @@ public void dispa
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r132838396
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/BrokerControllerTest.java ---
@@ -37,16 +37,14 @@
*/
@Test
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r132838549
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -95,14 +95,15 @
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW this PR has been merged into `develop` branch and will be
released in next version, you can close it now safely.
---
If your project is set up for it, you can reply to th
Github user Ritabrata-TW closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user Ritabrata-TW commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@zhouxinyu Thanks a lot. Will look forward to working with you again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/144
Actually, the existing design is that : we have a default name server
service address, which will be specified in our doc(though it is indeed not
demonstrated well for now), the default
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/144
@qqeasonchen also, please notice your tittle to make it complete. And link
the jira issue in the desciption
---
If your project is set up for it, you can reply to this email and have your
Github user solosky commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r132864458
--- Diff: common/src/main/java/org/apache/rocketmq/common/UtilAll.java ---
@@ -184,15 +184,27 @@ public static String timeMillisToHumanString3(fin
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12817918)
Coverage increased (+0.6%) to 39.637% when pulling
**e3988d3fa66a76e
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/129
[](https://coveralls.io/builds/12817918)
Coverage increased (+0.6%) to 39.637% when pulling
**e3988d3fa66a76e
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/145
[](https://coveralls.io/builds/12817903)
Coverage decreased (-0.06%) to 39.011% when pulling
**7c6d268934bbbd
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/144
[](https://coveralls.io/builds/12819006)
Coverage decreased (-0.1%) to 38.925% when pulling
**2081bd43cdb15ec
19 matches
Mail list logo
