[GitHub] incubator-rocketmq pull request #146: [ROCKETMQ-265] fix consume queue’s d...

2017-08-14 Thread fuyou001
GitHub user fuyou001 opened a pull request: https://github.com/apache/incubator-rocketmq/pull/146 [ROCKETMQ-265] fix consume queue’s data maybe repeat bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/fuyou001/incubator-rocke

[GitHub] incubator-rocketmq issue #146: [ROCKETMQ-265] fix consume queue’s data may...

2017-08-14 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/146 @fuyou001 Could you verify your polish using unit-test ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq issue #146: [ROCKETMQ-265] fix consume queue’s data may...

2017-08-14 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/146 Please add a link to the JIRA issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] incubator-rocketmq issue #146: [ROCKETMQ-265] fix consume queue’s data may...

2017-08-14 Thread fuyou001
Github user fuyou001 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/146 @vongosling unit test add --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] incubator-rocketmq-externals issue #26: MySQL:To prepare release mysql repli...

2017-08-14 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/26 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] incubator-rocketmq-externals issue #19: [DISCUSS]Go-Client:Detail Design

2017-08-14 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/19 How are things going, now :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] incubator-rocketmq-externals pull request #26: MySQL:To prepare release mysq...

2017-08-14 Thread zhaoqun911
Github user zhaoqun911 closed the pull request at: https://github.com/apache/incubator-rocketmq-externals/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re:[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code

2017-08-14 Thread 王启伟
Hi, Very appreciated to receive your suggestion, I had fixed it by commit: a242505ae7e3ea0bcdc4ace3dcf53ccf331f89b7. Thanks! At 2017-08-13 17:22:59, "lizhanhui" wrote: >Github user lizhanhui commented on the issue: > >https://github.com/apache/incubator-rocketmq-externals/pull/27

Re:[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code

2017-08-14 Thread 王启伟
Hi, Files in example are showing how rocketmq-cpp producer and consumer works, it is useful for new users, we keep it now better. Thanks. At 2017-08-13 17:47:46, "lizhanhui" wrote: >Github user lizhanhui commented on the issue: > >https://github.com/apache/incubator-rocketmq-external

[GitHub] incubator-rocketmq pull request #147: Can’t start consumer with a small co...

2017-08-14 Thread mark800
GitHub user mark800 opened a pull request: https://github.com/apache/incubator-rocketmq/pull/147 Can’t start consumer with a small consumerThreadMax number Can’t start consumer with a small consumerThreadMax number -- When the client set the consumerThreadMax to

[GitHub] incubator-rocketmq-externals issue #19: [DISCUSS]Go-Client:Detail Design

2017-08-14 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/19 We develop the go rocketmq client base on this design ,and the development work has been completed. Now we are refactoring it to make it better. For example, make api st

[GitHub] incubator-rocketmq issue #147: Can’t start consumer with a small consumerT...

2017-08-14 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [![Coverage Status](https://coveralls.io/builds/12823734/badge)](https://coveralls.io/builds/12823734) Coverage decreased (-0.3%) to 38.465% when pulling **6288e5696aa8287

[GitHub] incubator-rocketmq issue #147: Can’t start consumer with a small consumerT...

2017-08-14 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [![Coverage Status](https://coveralls.io/builds/12823734/badge)](https://coveralls.io/builds/12823734) Coverage decreased (-0.3%) to 38.465% when pulling **6288e5696aa8287

Re:Re:[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code

2017-08-14 Thread 王启伟
Hi All, For build and install, cmake and Makefile are all supported on linux platform now. Thanks. At 2017-08-14 20:47:31, "王启伟" wrote: Hi, Very appreciated to receive your suggestion, I had fixed it by commit: a242505ae7e3ea0bcdc4ace3dcf53ccf331f89b7. Thanks! At 2017-08-13

[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code

2017-08-14 Thread vincentWangKB
Github user vincentWangKB commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 For build and install, cmake and Makefile are all supported on linux platform now. Thanks --- If your project is set up for it, you can reply to this email and have your r

[GitHub] incubator-rocketmq issue #147: Can’t start consumer with a small consumerT...

2017-08-14 Thread vsair
Github user vsair commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 Thanks for your contributions. But, 1. Please refer to http://rocketmq.apache.org/docs/pull-request/, then modify your pr title. 2. Please change the merge target to develop. --- I

[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code

2017-08-14 Thread vincentWangKB
Github user vincentWangKB commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 @lizhanhui all build issue had been fixed, please pull latest code, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on G