[GitHub] incubator-rocketmq issue #148: [ROCKETMQ-269] don’t need cal.setTimeInMill...

2017-08-16 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/148 @mark800 Thanks!! Would you please add an unit test for this in the pr? Also, please modify the pr title to make it complete --- If your project is set up for i

[GitHub] incubator-rocketmq pull request #147: [ROCKETMQ-266] Add a specific Exceptio...

2017-08-16 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/147#discussion_r133633277 --- Diff: client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java --- @@ -0,0 +1,48 @@ +/* + * L

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread Jaskey Lam
+1 it is great that more users and contributors are getting invoked with RocketMQ. Graduation will let RocketMQ help more user to build amazing internet applications! On Thu, Aug 17, 2017 at 2:22 PM, Roman Shtykh wrote: > +1 (not binding) > > Excellent!! > -- Roman > > > On Wednesday, Augus

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread Roman Shtykh
+1 (not binding) Excellent!! -- Roman On Wednesday, August 16, 2017 10:49 AM, Von Gosling wrote: Hi, Following the discussion in Apache RocketMQ PPMC on graduating Apache RocketMQ from incubation to a Top Level Project, starting this voting thread within the RocketMQ community. A

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread wenfeng wang
+1 Working with the community is very pleasure, : ) ~ 2017-08-17 7:58 GMT+08:00 Justin Mclean : > +1 - great job everyone >

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread Justin Mclean
+1 - great job everyone

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread Bruce Snyder
+1 (binding) Bruce On Tue, Aug 15, 2017 at 7:48 PM, Von Gosling wrote: > Hi, > > Following the discussion in Apache RocketMQ PPMC on graduating Apache > RocketMQ from incubation to a Top Level Project, starting this voting > thread within the RocketMQ community. > > Apache RocketMQ entered into

[GitHub] incubator-rocketmq-externals issue #11: [ROCKETMQ-129] Initialized the rocke...

2017-08-16 Thread Jothipandiyan-jp1
Github user Jothipandiyan-jp1 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/11 Is there any plan for releasing c++ windows SDK in upcoming weeks? Is c# SDK is going to release? --- If your project is set up for it, you can reply to this emai

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread Xin Wang
+1 We see the active community and the effort of building a good eco-system. Thanks, Xin 2017-08-16 21:28 GMT+08:00 lollipop : > +1 > > During the process of incubation, the RocketMQ user base has been steadily > growing, with more and more organizations adopting RocketMQ to set up a > reliable

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread yukon
+1 for graduation. I feel lucky enough to be able to follow Apache RocketMQ community all the way. RocketMQ's rapid development is amazing, hope RocketMQ could serve open source community better at new stage as a TLP. Regards, yukon On Wed, Aug 16, 2017 at 7:35 PM, qun <9...@zhaoqun911.cn> wrote

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread lollipop
+1 During the process of incubation, the RocketMQ user base has been steadily growing, with more and more organizations adopting RocketMQ to set up a reliable and scalable messaging middleware. On Wed, Aug 16, 2017 at 9:48 AM, Von Gosling wrote: > Hi, > > Following the discussion in Apache Rock

回复: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread qun
Hi, Following the discussion in Apache RocketMQ PPMC on graduating Apache RocketMQ from incubation to a Top Level Project, starting this voting thread within the RocketMQ community. Apache RocketMQ entered into incubation during Nov. 2016. Since then, we announced two incubating versions(pass

[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code

2017-08-16 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 I suggest that we'd better squash the commits before merging a PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code

2017-08-16 Thread vincentWangKB
Github user vincentWangKB commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 @lizhanhui alog lib had been instead by boost::log, thanks your advisement --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-rocketmq issue #148: [ROCKETMQ-269] don’t need cal.setTimeInMill...

2017-08-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/148 [![Coverage Status](https://coveralls.io/builds/12855105/badge)](https://coveralls.io/builds/12855105) Coverage decreased (-0.07%) to 38.713% when pulling **776ddb918f15e8

[GitHub] incubator-rocketmq issue #148: [ROCKETMQ-269] don’t need cal.setTimeInMill...

2017-08-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/148 [![Coverage Status](https://coveralls.io/builds/12855105/badge)](https://coveralls.io/builds/12855105) Coverage decreased (-0.07%) to 38.713% when pulling **776ddb918f15e8

[GitHub] incubator-rocketmq issue #148: [ROCKETMQ-269] don’t need cal.setTimeInMill...

2017-08-16 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/148 [![Coverage Status](https://coveralls.io/builds/12855105/badge)](https://coveralls.io/builds/12855105) Coverage decreased (-0.07%) to 38.713% when pulling **776ddb918f15e8

[GitHub] incubator-rocketmq pull request #148: [ROCKETMQ-269] don’t need cal.setTim...

2017-08-16 Thread mark800
GitHub user mark800 opened a pull request: https://github.com/apache/incubator-rocketmq/pull/148 [ROCKETMQ-269] don’t need cal.setTimeInMillis(System.currentTimeMillis()) after Cale… don’t need cal.setTimeInMillis(System.currentTimeMillis()) after Calendar.getInstance()

Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-16 Thread liuxue
+1 In the last 8 months incubating, RocketMQ has attracted friends from all over the world to use or contribute. Community incubated some integrated projects, multi-language version clients and some good features. I believe RocketMQ will be getting better and better. On Wed, Aug 16, 2017 at 2:10