[GitHub] incubator-rocketmq issue #156: [ROCKETMQ-271] add tools for Analyzing messag...

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/156 [](https://coveralls.io/builds/13178521) Coverage decreased (-1.6%) to 37.094% when pulling **94ffbc330843818

[GitHub] incubator-rocketmq issue #155: [ROCKETMQ-280] improve dependency management ...

Github user qqeasonchen commented on the issue: https://github.com/apache/incubator-rocketmq/pull/155 @zhouxinyu @lizhanhui @Jaskey can this be merged? ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

Github user leonchen83 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 I recommend using travis ci to do integration test as other open source project. but first need to add this sub-project to travis ci. I have no permission to do this.

[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/162 @vsair Could you follow our new PR style for this PR, like https://github.com/apache/incubator-rocketmq/pull/152 ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 Consider this is the first commit for this project, I would like to recommend creating one module naming test for integration test :-) ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

Github user leonchen83 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 any reference or example for step 4 ? @vongosling ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed

Re: Check List for Pull Request

Hi, Thanks yukon. Consider Github markdown syntax, we can paste code from here[1]. Another good practice for pr, we can learn from here[2]. Enjoy it :-) [1] http://rocketmq.apache.org/docs/pull-request/#check-list-for-a-pr [2

[GitHub] incubator-rocketmq-externals issue #23: [ROCKETMQ-193] init subproject: rock...

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/23 @Zhang-Ke Thanks, It is really good practice when discarded deserted pr. ---

[GitHub] incubator-rocketmq-externals issue #23: [ROCKETMQ-193] init subproject: rock...

Github user Zhang-Ke commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/23 Please see #29 instead, and this PR was discarded. ---

Check List for Pull Request

Hi guys, To help us handle pull request quickly and easily, we added a check list for a pull request[1]: - [x] Make sure there is a [JIRA issue]( https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do