Github user kevin-better commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/150#discussion_r139874392
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1094,34 +1090,15 @@ private boolean
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/166
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/57
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/81
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/164
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/38
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/117
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/99
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/167
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/20
---
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/150#discussion_r139873296
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1094,34 +1090,15 @@ private boolean
Github user kevin-better commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/150
@dongeforever ok
---
Github user kevin-better closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/150
---
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139871853
--- Diff:
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
---
@@ -63,11 +65,36 @@ public
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/152
LGTM @zhouxinyu @vongosling
---
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/153
@evthoriz may you mock a test for this scenario?
---
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/154
@zwillim I want to merge this PR. Could you please change the target branch
to apache:develop ?
As all the PRs are merged into develop at first.
---
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/156#discussion_r139868962
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/ServerTracerTimeUtil.java ---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/156#discussion_r139869169
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/mqtrace/TrackerTimeSendMessageHook.java
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/156
LGTM @zhouxinyu @vongosling
---
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/165
@wenweihu86 By default, the commitlog will flush in real-time. If enable
flushCommitLogTimed, then it will flush at the interval.
So there is no need to sleep 100 ms, 10 is
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/167
@warning5 this pr has no files changed.
---
22 matches
Mail list logo
