Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/170
No Code change,and this pr will close.
---
Github user zwillim commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/154
@dongeforever ok.
---
Github user zwillim closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/154
---
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@shroman It seems that last cleaning, for too long-time no-resolved prs,
included this one.
If you feel it is necessary to reopen this PR, please feel free to do it.
you may a
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/170
[](https://coveralls.io/builds/13385293)
Coverage increased (+0.01%) to 38.573% when pulling
**c4675f6322ae67
GitHub user warning5 opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/170
Merge pull request #1 from apache/master
update from origin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/warning5/incubator-rocke
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/133
[](https://coveralls.io/builds/13384852)
Coverage increased (+0.3%) to 38.964% when pulling
**ba0348b972cbab3
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
And why is it closed?
---
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140425575
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1509,65 +1514,62 @@ private boolean isTimeToDelete() {
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140425644
--- Diff:
store/src/test/java/org/apache/rocketmq/store/CleanCommitLogServiceTest.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apac
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/133
@dongeforever Modified as you suggested, thanks!
---
11 matches
Mail list logo
