[GitHub] incubator-rocketmq-externals pull request #28: [ROCKETMQ-282]RocketMQ-GO-Cli...

2017-08-29 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/28 [ROCKETMQ-282]RocketMQ-GO-Client [ROCKETMQ-282 RocketMQ-GO-Client](https://issues.apache.org/jira/browse/ROCKETMQ-282) [Document](https://github.com/StyleTang/incubator

[GitHub] incubator-rocketmq-externals pull request #19: [DISCUSS]Go-Client:Detail Des...

2017-08-15 Thread StyleTang
Github user StyleTang closed the pull request at: https://github.com/apache/incubator-rocketmq-externals/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq-externals issue #19: [DISCUSS]Go-Client:Detail Design

2017-08-14 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/19 We develop the go rocketmq client base on this design ,and the development work has been completed. Now we are refactoring it to make it better. For example, make api

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-08-11 Thread StyleTang
Github user StyleTang closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-08-11 Thread StyleTang
Github user StyleTang closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-08-11 Thread StyleTang
GitHub user StyleTang reopened a pull request: https://github.com/apache/incubator-rocketmq/pull/103 [ROCKETMQ-198]add LanguageCode for GO and PHP https://issues.apache.org/jira/browse/ROCKETMQ-198 LanguageCode without GO. The language can only use OTHER ![go-client

[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-05-12 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq/pull/103 [ROCKETMQ-198]add LanguageCode for GO and PHP https://issues.apache.org/jira/browse/ROCKETMQ-198 LanguageCode without GO. The language can only use OTHER ![go-client-consumer

[GitHub] incubator-rocketmq-externals issue #22: Go-Client's implement

2017-05-12 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/22 To Be Done - [ ] Integration Testing(There is no Integration Testing) - [ ] Clean Code(Some code needs to be refactored ) --- If your project is set up for it, you

[GitHub] incubator-rocketmq-externals pull request #22: Go-Client's implement

2017-05-12 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/22 Go-Client's implement All features of milestone 1 has been completed Detail Design: https://github.com/apache/incubator-rocketmq-externals/pull/19 # Ro

[GitHub] incubator-rocketmq-externals issue #19: [DISCUSS]Go-Client:Detail Design

2017-05-07 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/19 As @wenfengwang 's suggestion. I will split MqClient into (MqClient/MqClientAPI/PullAPIWrapper) --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-rocketmq-externals issue #18: Go client: implement MQClientAPI and...

2017-05-07 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/18 Well done :-) We should make sure that the example can be executed correctly. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rocketmq-externals pull request #19: [DISCUSS]Go-Client:Detail Des...

2017-05-07 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/19 [DISCUSS]Go-Client:Detail Design see https://github.com/StyleTang/incubator-rocketmq-externals/tree/detail-design-rebase/rocketmq-go Please don't merge the PR.

[GitHub] incubator-rocketmq-externals issue #17: Go-Client remoting and RocketMqClien...

2017-05-05 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/17 I had discuss the implement of remoting package with @wenfengwang The PR can be merged, please review. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-rocketmq-externals pull request #17: Go-Client remoting and Rocket...

2017-05-05 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/17 Go-Client remoting and RocketMqClient common method implement Go-Client remoting and RocketMqClient common method implement You can merge this pull request into a Git

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

2017-04-23 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 Well done. @wenfengwang There are still some minor problems here, but I think we can merge it first. I will implement the package of remoting base on it. --- If

[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...

2017-04-23 Thread StyleTang
Github user StyleTang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-externals/pull/13#discussion_r112835033 --- Diff: rocketmq-go/model/response_code.go --- @@ -0,0 +1,67 @@ +package model + +const ( + // success

[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...

2017-04-23 Thread StyleTang
Github user StyleTang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-externals/pull/13#discussion_r112834996 --- Diff: rocketmq-go/hook/rpchook.go --- @@ -14,4 +14,10 @@ * See the License for the specific language governing permissions

[GitHub] incubator-rocketmq-externals pull request #10: RocketMQ-Go-Client-Init

2017-04-16 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/10 RocketMQ-Go-Client-Init Add rocketmq go client's design, roadmap and package. ![alternative text](http://www.plantuml.com/plantuml/proxy?src=

[GitHub] incubator-rocketmq-externals issue #8: update console's readme

2017-04-01 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/8 users and dev mailing lists has been added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-rocketmq-externals pull request #8: update console's readme

2017-03-31 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/8 update console's readme update console's readme You can merge this pull request into a Git repository by running: $ git pull https://github.com/StyleTang

[GitHub] incubator-rocketmq-externals pull request #6: Update rocketmq console's read...

2017-03-31 Thread StyleTang
Github user StyleTang closed the pull request at: https://github.com/apache/incubator-rocketmq-externals/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq-externals pull request #6: Update rocketmq console's read...

2017-03-30 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/6 Update rocketmq console's readme.md Update rocketmq console readme.md You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] incubator-rocketmq-externals pull request #2: fix cluster page's bug.

2017-03-17 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/2 fix cluster page's bug. https://github.com/rocketmq/rocketmq-console-ng/issues/33 After the master node goes down, the cluster page displays the Slave as Master and

[GitHub] incubator-rocketmq-externals pull request #1: update console's readme and co...

2017-03-15 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/1 update console's readme and consumer's code 1.update read me format. 2.add try catch for queryConsumeStatsList is better 3.use examineConsumeStats(groupName,

[GitHub] incubator-rocketmq issue #72: [ROCKETMQ-134]the offset of message filter by ...

2017-03-08 Thread StyleTang
Github user StyleTang commented on the issue: https://github.com/apache/incubator-rocketmq/pull/72 @Jaskey I found pullStatus is final, and I don't want to redefine it, so I judge the msgList size. may be change the value of pullStatus will be better. As you say

[GitHub] incubator-rocketmq pull request #72: https://issues.apache.org/jira/browse/R...

2017-03-08 Thread StyleTang
GitHub user StyleTang opened a pull request: https://github.com/apache/incubator-rocketmq/pull/72 https://issues.apache.org/jira/browse/ROCKETMQ-134 when different string has a same hash code.the message commit offset of filtered message may be not commit to broker. for example