[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-09-19 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @dongeforever thanks for your reply. I tried, but it seems that there's no easy way to mock a test for this, since the ha mechanism involves lots of salve replicating behavior. D

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-28 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @vongosling @zhouxinyu @shroman @lizhanhui Anybody willing to review this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @Jaskey Another key condition is the MASTER-SLAVE replicating mode, which is SYNC_MASTER in the case. However, the option `syncFlushTimeout` is useless not only for big messages

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @Jaskey This issue can be easily reproduced with the config I provided in Jira. Please take a look at the description there. --- If your project is set up for it, you can reply to this

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @vongosling @zhouxinyu The CI environment is not correctly set. Would you guys have a loot at that? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 @shroman @vongosling It seems that plenty of tests are associated with this modification, I will resubmit a patch when I complete the relevant integration test. --- If your project is

[GitHub] incubator-rocketmq pull request #153: [ROCKETMQ-272] Fix sync slave timeout ...

2017-08-24 Thread evthoriz
GitHub user evthoriz opened a pull request: https://github.com/apache/incubator-rocketmq/pull/153 [ROCKETMQ-272] Fix sync slave timeout when using SYNC_MASTER Jira: https://issues.apache.org/jira/browse/ROCKETMQ-272 The timeout logic doesn't work correctly. T

[GitHub] incubator-rocketmq pull request #132: [ROCKETMQ-248] make ConsumeFromWhere w...

2017-07-21 Thread evthoriz
GitHub user evthoriz opened a pull request: https://github.com/apache/incubator-rocketmq/pull/132 [ROCKETMQ-248] make ConsumeFromWhere work right JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-248 You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...

2017-06-28 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/128 @Jaskey From the aspect of client, every batch request would cause printing 2 warning logs. But the further influence is it may damage the performance in high throughput scenario where

[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...

2017-06-27 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/128 @zhouxinyu JIRA issue attached. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-rocketmq pull request #128: bugix in batch scenario

2017-06-27 Thread evthoriz
GitHub user evthoriz opened a pull request: https://github.com/apache/incubator-rocketmq/pull/128 bugix in batch scenario Bug in handle batch response. It will write response twice to client in batch scenario. You can merge this pull request into a Git repository by running