[GitHub] incubator-rocketmq issue #45: [ROCKETMQ-54] Polish unit tests for rocketmq-n...

Github user iskl commented on the issue: https://github.com/apache/incubator-rocketmq/pull/45 I've merged this branch from remote master. The integration test on OSX are all passed. Thanks~ --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-rocketmq pull request #45: [ROCKETMQ-54] Polish unit tests for roc...

GitHub user iskl opened a pull request: https://github.com/apache/incubator-rocketmq/pull/45 [ROCKETMQ-54] Polish unit tests for rocketmq-namesrv [Issue ref link](https://issues.apache.org/jira/browse/ROCKETMQ-54) This PR is in continuous delivery. About 25% in progress

[GitHub] incubator-rocketmq issue #43: [ROCKETMQ-59] Change Charset usages in RocketM...

Github user iskl commented on the issue: https://github.com/apache/incubator-rocketmq/pull/43 @zhouxinyu That's really a better solution! I've change the access modifiers to `private` for borh. Since the CHARSET is used in `static` methods, it could not be modifi

[GitHub] incubator-rocketmq pull request #43: [ROCKETMQ-59] Change Charset usages in ...

GitHub user iskl opened a pull request: https://github.com/apache/incubator-rocketmq/pull/43 [ROCKETMQ-59] Change Charset usages in RocketMQSerializable to Rocket… The PR is to resolve [issue-59](https://issues.apache.org/jira/browse/ROCKETMQ-59) You can merge this pull request

[GitHub] incubator-rocketmq pull request #37: [ROCKETMQ-38] Some unit tests for rocke...

Github user iskl commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/37#discussion_r96157152 --- Diff: remoting/src/test/java/org/apache/rocketmq/remoting/protocol/RemotingCommandTest.java --- @@ -0,0 +1,222 @@ +/* + * Licensed to

[GitHub] incubator-rocketmq issue #37: [ROCKETMQ-38] Some unit tests for rocketmq-rem...

Github user iskl commented on the issue: https://github.com/apache/incubator-rocketmq/pull/37 @shroman , issue-38 is for the whole rocketmq-remoting submoudle. The code already committed is the sample just for code style suggestion. I am writing the remaining test cases and nearly

[GitHub] incubator-rocketmq pull request #37: [ROCKETMQ-38] Some unit tests for rocke...

Github user iskl commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/37#discussion_r95756507 --- Diff: remoting/src/test/java/org/apache/rocketmq/remoting/protocol/RemotingCommandTest.java --- @@ -0,0 +1,227 @@ +/* + * Licensed to

[GitHub] incubator-rocketmq issue #37: [ROCKETMQ-38] Some unit tests for rocketmq-rem...

Github user iskl commented on the issue: https://github.com/apache/incubator-rocketmq/pull/37 @zhouxinyu Apologize... It's my mistake to use a wrong version of assertj.-core I've modified it to the correct version for jdk7 :) --- If your project is set up for it, you ca

[GitHub] incubator-rocketmq pull request #37: [ROCKETMQ-38] Some unit tests for rocke...

GitHub user iskl opened a pull request: https://github.com/apache/incubator-rocketmq/pull/37 [ROCKETMQ-38] Some unit tests for rocketmq-remoting [ref issue](https://issues.apache.org/jira/browse/ROCKETMQ-38). I wish to improve unit test coverage for RocketMQ and wrote these

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

Github user iskl commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 Dear @shroman , thanks for your suggestion :) In my concept, broker thread is **time sensitive**. When broker thread in a MQ broker is in I/O operation and GC occurs, an **I/O

[GitHub] incubator-rocketmq pull request #29: [ROCKETMQ-31] Fix "No such file or dire...

GitHub user iskl opened a pull request: https://github.com/apache/incubator-rocketmq/pull/29 [ROCKETMQ-31] Fix "No such file or directory" warning for $HOME/rmq_b… The PR is to resolve the issue [ROCKETMQ-31](https://issues.apache.org/jira/browse/ROCKETMQ-31) You can