Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@zhouxinyu @vongosling pls have a review ?
---
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@vongosling I'v modified the description.
---
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/162
[ROCKETMQ-286] Add a switch to decide whether to wake up commitLogService
when put message
https://issues.apache.org/jira/browse/ROCKETMQ-286
You can merge this pull request into a Git
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@zhouxinyu @lizhanhui @vongosling pls have a review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/161
Thanks for your contribution, but please read the contributor's guide
first. Then, you would,
1. Create an jira issue, and rename the pr's title and description.
2.
Github user vsair closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135773045
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -79,24 +79,17 @@
try
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/160#discussion_r135745011
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -369,4 +367,36 @@ public void
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/160
@vongosling pls have a review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/160
[ROCKETMQ-284] ExpressionMessageFilter will pass some message.
https://issues.apache.org/jira/browse/ROCKETMQ-284
Solution:
Keep the tagscode transfer into MessageFilter
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/152
nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/146
LGTM, but be careful to upgrade. If the situation already happened at a
server, then upgrade to this feature, it will miss some messages. It would be
better to have some mechanism to keep
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134968491
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -97,54 +110,46 @@ public MessageExtBrokerInner
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134969821
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -43,15 +43,24 @@
private SocketAddress
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134970255
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -92,9 +92,9
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134970377
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -97,54 +110,46 @@ public MessageExtBrokerInner
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/150
what is the purpose of this issue? it confused me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/147
Thanks for your contributions. But,
1. Please refer to http://rocketmq.apache.org/docs/pull-request/, then
modify your pr title.
2. Please change the merge target to develop
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
Is there something wrong with your code style ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130556323
--- Diff:
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java ---
@@ -99,7 +111,12 @@ private static Logger createLogger(final
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/137
I think you may have a look at the contributor's guideline.
http://rocketmq.apache.org/docs/pull-request/
---
If your project is set up for it, you can reply to this emai
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
Any description about this PR ? Or, you could add the jira link.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r129468820
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -745,17 +751,7 @@ public long getMessageStoreTimeStamp
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r129469074
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1215,9 +1199,14 @@ public TopicRouteData
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r129468910
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -717,22 +717,28 @@ public long getEarliestMessageTime
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/118#discussion_r127149807
--- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java
---
@@ -173,12 +177,20 @@ public void setVipChannelEnabled(final
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/130#discussion_r126856546
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/BrokerData.java
---
@@ -37,15 +41,21 @@ public BrokerData(String cluster
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
Hi, Jaskey;
Thanks for your question.
1. It will decode the properties to do calculation at that case.
2. When they are changed, the consumer's subscription wi
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/115#discussion_r121035368
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -621,34 +621,23 @@ public boolean
Github user vsair closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/92
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115475862
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -907,10 +907,10 @@ public void queryMessage
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478367
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/header/QueryMessageResponseHeader.java
---
@@ -28,7 +28,7
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478015
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
---
@@ -27,23 +27,23 @@
public class
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/11
[ROCKETMQ-121]Docs of filtering messages based on SQL92
Docs of filtering messages based on SQL92.
PR, already merged to develop:
https://github.com/apache/incubator
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/16
Hi,would you please notice me when you have more detailed design?
As I know, there are many open sources have implemented parser of binary
log, I'm very interested in
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
Hi, Thanks for your contribution! But, could you please rename the title,
like, [ROCKETMQ-XXX]?
Also, you should create an issue at
https://issues.apache.org/jira/browse/ROCKETMQ
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/86
IMO, it's good and reasonable that counter should record the heartbeat's
real request.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vsair closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vsair closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
@zhouxinyu Conflicts have been resolved. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/16
Is the purpose of RocketMQ-MySQL to dump binlog into queue? And, client
could sub binlog from RocketMQ ?
---
If your project is set up for it, you can reply to this email
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
+1, maybe it's better to merge JAVA_OPTS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/12
[ROCKETMQ-183] Play Script to run broker and namesrv at local in docker
A script is needed to run broker and namesrv at local in docker.
1. Set link flag to make containers
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
When running in docker, this would be useful. Users just want to run a
docker demo, but the computer could not allocate 8g memory, and there is no way
to define the JVM flags in docker&#
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
@vongosling yeah, only server's modules have guava dependency, client
doesn't.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/92
Yeah, you're right. There is no way to solve the problem in existing design.
But the result is :
when user stop the consumer has diff subscription, broker could hold the
co
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/94
[ROCKETMQ-179] Fix errors of test cases
1. Add TC of ConsumerManager.
2. Fix some bugs.
3. Set file size of commitlog to 256M, instead of 1G(may too big).
4. Destroy message
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/92
This PR does't break the restrict that all consumers should have the same
subscription. It only focus on broker should hold the online consumer's
subscription. Miss messages i
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/92
[ROCKETMQ-175] Consumer may miss messages because of inconsistent subâ¦
For push mode, update subscription version when rebalance result changed,
then send heart beat to broker
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/28
@Jaskey yeah, it's true that rocketmq will delete commit logs when disk
is full, even though not expired.
---
If your project is set up for it, you can reply to this email and have
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r110845437
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filter/ConsumerFilterData.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r110845213
--- Diff:
filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java ---
@@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/7
I have test on windows 7(installed docker toolbox 1.11.1), the result is:
1. Should run _docker-machine_ first, it will tell you set some envs.
```
SET
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/82#discussion_r109138716
--- Diff:
filter/src/main/java/org/apache/rocketmq/filter/util/HashAlgorithm.java ---
@@ -0,0 +1,239 @@
+/*
+ * Licensed to the Apache
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/70
[ROCKETMQ-95] fix damaged patterns
https://issues.apache.org/jira/browse/ROCKETMQ-95
Correct wrong patterns.
You can merge this pull request into a Git repository by running
56 matches
Mail list logo
