[GitHub] incubator-rocketmq-externals issue #22: Go-Client's implement

2017-07-04 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/22 Can this PR be merged? I would like to do some optimization and add tests based on this PR. Thanks~ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-rocketmq-externals issue #22: Go-Client's implement

2017-05-14 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/22 Cool~The PR looks good to me. Because the personal things are more recently, I'm so sorry that i don't have much free time to contribute. Thanks @StyleTang. -

[GitHub] incubator-rocketmq-externals pull request #18: Go client: implement MQClient...

2017-05-12 Thread wenfengwang
Github user wenfengwang closed the pull request at: https://github.com/apache/incubator-rocketmq-externals/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq-externals issue #18: Go client: implement MQClientAPI and...

2017-05-12 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/18 Use @StyleTang 's implementation, I close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-rocketmq-externals pull request #18: Go client: implement MQClient...

2017-05-07 Thread wenfengwang
GitHub user wenfengwang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/18 Go client: implement MQClient and a part of PullConsumer You can merge this pull request into a Git repository by running: $ git pull https://github.com/wenfengwang

[GitHub] incubator-rocketmq-externals issue #17: Go-Client remoting and RocketMqClien...

2017-05-06 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/17 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

2017-04-24 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 @zhouxinyu The PR can be merged, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

2017-04-23 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 I hava fix Chinese docs's translation, and solved the cycle dependence problem. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

2017-04-23 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 @zhouxinyu Can you point out the Chinese docs in this PR, I didn't find it. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...

2017-04-23 Thread wenfengwang
Github user wenfengwang commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/13 @zhouxinyu Hi yukon, the PR can be merged, which mainly include: *Basic Model: message, (pull/query/send)_result, topic, header, config, constants *Remoting: Not

[GitHub] incubator-rocketmq-externals pull request #13: RocketMQ Go SDK implementatio...

2017-04-19 Thread wenfengwang
GitHub user wenfengwang opened a pull request: https://github.com/apache/incubator-rocketmq-externals/pull/13 RocketMQ Go SDK implementation Hi, some works have not yet complete, please not merge the PR. Welcome any guys provide any reviews, suggestions, etc. You can merge this