[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

2017-09-10 Thread leonchen83
Github user leonchen83 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 @vongosling you will see the result of integration-test at [incubator-rocketmq-externals](https://travis-ci.org/leonchen83/incubator-rocketmq-externals/branches) ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

2017-09-10 Thread leonchen83
Github user leonchen83 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 @vongosling I already added an integration-test to rocketmq-redis-replicator base on travis-ci. please help review this commit ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

2017-09-07 Thread leonchen83
Github user leonchen83 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 I recommend using travis ci to do integration test as other open source project. but first need to add this sub-project to travis ci. I have no permission to do this.

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

2017-09-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 Consider this is the first commit for this project, I would like to recommend creating one module naming test for integration test :-) ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

2017-09-07 Thread leonchen83
Github user leonchen83 commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 any reference or example for step 4 ? @vongosling ---

[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...

2017-09-07 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/29 Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed