[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-09-19 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @dongeforever thanks for your reply. I tried, but it seems that there's no easy way to mock a test for this, since the ha mechanism involves lots of salve replicating behavior. Do you ha

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-09-19 Thread dongeforever
Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @evthoriz may you mock a test for this scenario? ---

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-28 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @vongosling @zhouxinyu @shroman @lizhanhui Anybody willing to review this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @Jaskey Another key condition is the MASTER-SLAVE replicating mode, which is SYNC_MASTER in the case. However, the option `syncFlushTimeout` is useless not only for big messages, but

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @evthoriz , so the scenario is for huge message. Please modify the jira title to make it clearer. But actually, I sent huge message before, but not able to reproduce it, so huge me

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @Jaskey This issue can be easily reproduced with the config I provided in Jira. Please take a look at the description there. --- If your project is set up for it, you can reply to this

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread Jaskey
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @evthoriz Would you please also point out that what kind of scenario will this issue be reproduced? --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread evthoriz
Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 @vongosling @zhouxinyu The CI environment is not correctly set. Would you guys have a loot at that? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] incubator-rocketmq issue #153: [ROCKETMQ-272] Fix sync slave timeout when us...

2017-08-24 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/153 [![Coverage Status](https://coveralls.io/builds/12971788/badge)](https://coveralls.io/builds/12971788) Coverage increased (+0.02%) to 39.051% when pulling **6f2501a24a7013