[GitHub] incubator-rocketmq pull request #150: [ROCKETMQ-273] return an expression wh...

2017-09-19 Thread kevin-better
Github user kevin-better commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/150#discussion_r139874392 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -1094,34 +1090,15 @@ private boolean

[GitHub] incubator-rocketmq pull request #150: [ROCKETMQ-273] return an expression wh...

2017-09-19 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/150#discussion_r139873296 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -1094,34 +1090,15 @@ private boolean

[GitHub] incubator-rocketmq pull request #150: [ROCKETMQ-273] return an expression wh...

2017-09-19 Thread kevin-better
Github user kevin-better closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/150 ---

[GitHub] incubator-rocketmq pull request #150: [ROCKETMQ-273] return an expression wh...

2017-08-24 Thread kevin-better
Github user kevin-better commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/150#discussion_r134944925 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -1094,34 +1090,15 @@ private boolean

[GitHub] incubator-rocketmq pull request #150: [ROCKETMQ-273] return an expression wh...

2017-08-24 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/150#discussion_r134941070 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -1094,34 +1090,15 @@ private boolean