GitHub user lindzh opened a pull request: https://github.com/apache/incubator-rocketmq/pull/169
[ROCKETMQ-292]Delete system.exit in MQAdminStartup ### What is the purpose of the change When using MQAdminStartup in a java process,some args problem may cause MQAdminStartup to call system.ext and this lead to main java process shutdown. JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-278. ### Brief change log * delete system.exit in mqadmin. ### Verifying this change * This change is a trivial rework / code cleanup without unit test coverage. * execute `mqadmin testa` to verify. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand the pull request : - What is the purpose of the change - Brief change log - Verifying this change - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-rocketmq/tree/master/test). - [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass. - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindzh/incubator-rocketmq fix_main_system.exit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 ---- commit 1ae0693693da4a147f1bb3c122833f548c376b09 Author: lindzh <linso...@163.com> Date: 2017-08-11T07:55:24Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit f0e243c5a8899fedc157accef964a1d617d77d1b Author: lindzh <linso...@163.com> Date: 2017-08-11T10:02:36Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit 1810be4c560767b83ff173e6fb6a96d4ac7c1428 Author: lindzh <linso...@163.com> Date: 2017-08-14T02:11:27Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit 53dcd8d0837eee419810f055a4035d3fdd72513f Author: lindzh <linso...@163.com> Date: 2017-08-22T12:34:49Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit 4abfa4f326d0f5ac7a01f43b3cb882a7916fac59 Author: lindzh <linso...@163.com> Date: 2017-08-28T10:41:53Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit d576e38db79e4437dc2b304a6d6ef3a0e9337f74 Author: lindzh <linso...@163.com> Date: 2017-08-30T06:38:39Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit bb446c48fa54cb542708f1ee171d49b1f6d1cd64 Author: lindzh <linso...@163.com> Date: 2017-09-21T07:15:43Z Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop commit a905b140d09d085d3c20aef4f08a6696e9b218bf Author: lindzh <linso...@163.com> Date: 2017-09-21T07:18:43Z fix main system.exit ---- ---