Re: Add planet-web to build process?

2013-03-24 Thread Glen Mazza
Hi Dave, no problem with separating out planet, but adding planet-web just adds 5 seconds to the build time (roughly 2% longer), at least on my machine, and is good for others looking at the code and for letting us know if/when a planet-web dependency has fallen out of date and is no longer ava

Rename RefererManager to ReferrerManager?

2013-03-24 Thread Glen Mazza
Hi, I'd like to implement https://issues.apache.org/jira/browse/ROL-1229, on at least 5.1 (possibly 5.0.2 as well). Any critical backwards compatibility problems if I do so? Another alternative is to close this issue as a "Won't Fix". (As "referer" is an HTTP term: http://en.wikipedia.org/w

Re: Add planet-web to build process?

2013-03-24 Thread Dave
On Sun, Mar 24, 2013 at 6:31 AM, Glen Mazza wrote: > Hi Dave, no problem with separating out planet, but adding planet-web just > adds 5 seconds to the build time (roughly 2% longer), at least on my > machine, and is good for others looking at the code and for letting us know > if/when a planet-w

Re: Rename RefererManager to ReferrerManager?

2013-03-24 Thread Dave
I could go either way on this one, so if you want to take action please decide and go ahead. However, I don't think we should address this in 5.0.x -- I think we should only address security issues and critical bugs there and a spelling error does not feel like a critical bug. Thanks, - Dave O

Re: Rename RefererManager to ReferrerManager?

2013-03-24 Thread Glen Mazza
I'll look at the source more thoroughly; we seem to be 50/50 between the two spellings. The *only* reason why I might want to apply it to 5.0.2 is because this change affects several files and it makes it easier to backport *other* patches and security fixes when the underlying files are ident

Re: Rename RefererManager to ReferrerManager?

2013-03-24 Thread Dave
On Sun, Mar 24, 2013 at 9:51 AM, Glen Mazza wrote: > I'll look at the source more thoroughly; we seem to be 50/50 between the > two spellings. The *only* reason why I might want to apply it to 5.0.2 is > because this change affects several files and it makes it easier to > backport *other* patch

Re: Rename RefererManager to ReferrerManager?

2013-03-24 Thread Anil Gangolli
Part of the origin of the problem is that the HTTP 1.0 Header has the misspelling. See http://en.wikipedia.org/wiki/HTTP_referer for the history. I think I made an effort long ago to correct it in our codebase where it was not a direct reference to the header name, but we may have regressed.