Re: Switch from catching Throwable to catching Exception instead?

2013-08-06 Thread Glen Mazza
I would still be catching Exception (which captures most everything anyway.) I don't think our code is throwing java.lang.Errors as a part of normal application processing, even during cleanup, those are for (should be) rare non-application system bugs that need to be handled by higher levels

Re: Switch from catching Throwable to catching Exception instead?

2013-08-06 Thread Anil Gangolli
Another type of situation where this may be warranted is in finally clauses doing cleanup, where one does not want an error to mask an original exception and the cleanup problem may be logged but not critical. --a. On 8/6/13 10:31 AM, Glen Mazza wrote: Yes, I'll look at them case-by-case

Re: Switch from catching Throwable to catching Exception instead?

2013-08-06 Thread Glen Mazza
Yes, I'll look at them case-by-case (if no objections from anyone else). Glen On 08/06/2013 01:20 PM, Anil Gangolli wrote: Some of these may be intended and necessary when catching IOError, NoClassDefFoundError and others. [At least the instance in GuiceWebloggerProvider, for example, seem

Re: Switch from catching Throwable to catching Exception instead?

2013-08-06 Thread Anil Gangolli
Some of these may be intended and necessary when catching IOError, NoClassDefFoundError and others. [At least the instance in GuiceWebloggerProvider, for example, seems to be there to catch the latter.] Some of them appear not to be needed, and it may be possible to make them more specific

Re: Pull out Atlassian Crowd from Roller?

2013-08-06 Thread Anil Gangolli
+1 On 8/6/13 9:10 AM, Dave wrote: +1 We need to provide ways for people to plugin things like this instead of adding deps to Roller. - Dave On Tue, Aug 6, 2013 at 12:08 PM, Glen Mazza wrote: Hi Team, I was looking at simplifying the number of external repositories that Roller relies on,

Switch from catching Throwable to catching Exception instead?

2013-08-06 Thread Glen Mazza
Hi folks, Sonar is complaining that in 34 cases[1] we're catching Throwable, which is not recommended as it ends up catching java.lang.Error messages (http://docs.oracle.com/javase/7/docs/api/java/lang/Error.html) for non-application system problems that should instead percolate up to the JDK

Re: Pull out Atlassian Crowd from Roller?

2013-08-06 Thread Dave
+1 We need to provide ways for people to plugin things like this instead of adding deps to Roller. - Dave On Tue, Aug 6, 2013 at 12:08 PM, Glen Mazza wrote: > Hi Team, I was looking at simplifying the number of external repositories > that Roller relies on, with the hopes that everything it

Pull out Atlassian Crowd from Roller?

2013-08-06 Thread Glen Mazza
Hi Team, I was looking at simplifying the number of external repositories that Roller relies on, with the hopes that everything it needs it can find from Maven Central, speeding up initial downloads and builds in the process. (I think it's also a good selling point for Roller that it can be bu