[GitHub] [roller] snoopdave commented on pull request #112: Minor fixes in Velocity Templates and dependency updates

2021-12-27 Thread GitBox
snoopdave commented on pull request #112: URL: https://github.com/apache/roller/pull/112#issuecomment-1001742386 Cool. I'm all for it if it makes things easier for folks using Netbeans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.

2021-12-27 Thread GitBox
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001671302 https://github.com/mikepenz/action-junit-report/issues/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.

2021-12-27 Thread GitBox
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001670124 oh haha. It published it in he CodeQL action https://github.com/apache/roller/actions/runs/1627718912 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.

2021-12-27 Thread GitBox
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001666008 it builds and tests but it didn't upload the test report (it should appear on the list on the left i think) https://github.com/apache/roller/actions/runs/1627718913 Don't

[GitHub] [roller] mbien merged pull request #113: Added github actions for basic build/test setup.

2021-12-27 Thread GitBox
mbien merged pull request #113: URL: https://github.com/apache/roller/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.

2021-12-27 Thread GitBox
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001661717 awesome. I merge it, lets see if everything builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [roller] mbien commented on pull request #112: Minor fixes in Velocity Templates and dependency updates

2021-12-27 Thread GitBox
mbien commented on pull request #112: URL: https://github.com/apache/roller/pull/112#issuecomment-1001653162 > Velocity changes LGTM. Do the Netbeans changes allow you to debug tests in the IDE? Its mostly for registering non-standard maven goals. like jetty:run, or the selenium

Re: Roller 6.1.1 RC #1 to fix MySQL 5.7 upgrade problem

2021-12-27 Thread Dave
I don't think that is the right behavior. Dave On Mon, Dec 27, 2021 at 3:22 AM Michael Bien wrote: > I noticed when upgrading from 6.1 to 6.1.1, Roller ran the upgrade > scripts again, is that intended? > > Its probably fine to run them twice even though nothing db related > changed in the

Re: Roller 6.1.1 RC #1 to fix MySQL 5.7 upgrade problem

2021-12-27 Thread Michael Bien
I noticed when upgrading from 6.1 to 6.1.1, Roller ran the upgrade scripts again, is that intended? Its probably fine to run them twice even though nothing db related changed in the patch release - i was still wondering. -michael On 24.12.21 23:49, Dave wrote: I put together a release