dependabot[bot] opened a new pull request, #120:
URL: https://github.com/apache/roller/pull/120
Bumps [spring-web](https://github.com/spring-projects/spring-framework) from
5.3.20 to 6.0.0.
Release notes
Sourced from https://github.com/spring-projects/spring-framework/releases";>sp
mbien commented on PR #119:
URL: https://github.com/apache/roller/pull/119#issuecomment-1344814362
some notes on dependency bumps:
- Spring 6 is released but it requires JDK 17, so I kept it at 5.x for now
since Roller is using 11 still
- Struts
[2.5.30](https://cwiki.apache.org/con
mbien commented on PR #119:
URL: https://github.com/apache/roller/pull/119#issuecomment-1344809941
there you go. Some test annotations were missing.
Whats interesting however is that the tests run in a different order on
github than they do on my system locally. Once the MediaFile tes
mbien commented on PR #119:
URL: https://github.com/apache/roller/pull/119#issuecomment-1344790720
ok thats weird. I can't explain right now why this PR started failing. Can't
reproduce this issue locally and I basically reverted everything already.
--
This is an automated message from th
mbien commented on PR #114:
URL: https://github.com/apache/roller/pull/114#issuecomment-1314286969
closing in favor of #119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mbien closed pull request #114: Merged CodeQL workflow into main workflow.
URL: https://github.com/apache/roller/pull/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
mbien opened a new pull request, #119:
URL: https://github.com/apache/roller/pull/119
- the test-summary action has [been green lit by
infra](https://issues.apache.org/jira/browse/INFRA-23445) for CI use and works
fairly well for the NetBeans project where we use it since then. The only
an
mbien merged PR #118:
URL: https://github.com/apache/roller/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org
mbien opened a new pull request, #118:
URL: https://github.com/apache/roller/pull/118
- jakarta namespace update allows roller to use eclipse link 3.x.
- minor dependency updates (asm, lucene, spring, jquery-ui webjar)
struts wasn't updated due to some breaking changes, see:
-
dependabot[bot] opened a new pull request, #117:
URL: https://github.com/apache/roller/pull/117
Bumps [struts2-core](https://github.com/apache/struts) from 2.5.29 to 2.5.30.
Commits
See full diff in https://github.com/apache/struts/commits";>compare view
[
mbien commented on pull request #116:
URL: https://github.com/apache/roller/pull/116#issuecomment-1086509966
verified that it works. It will only upload the artifact during integration,
not during PR checks to conserve resources.
example at bottom of the page:
https://github.com/apach
mbien merged pull request #116:
URL: https://github.com/apache/roller/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien opened a new pull request #116:
URL: https://github.com/apache/roller/pull/116
upload a dev build as CI step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
mbien merged pull request #115:
URL: https://github.com/apache/roller/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien commented on pull request #115:
URL: https://github.com/apache/roller/pull/115#issuecomment-1086409287
merging (without review) to make it easier for users to build roller with
the spring fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mbien opened a new pull request #115:
URL: https://github.com/apache/roller/pull/115
- **notable dependency update: spring 5.3.18** with **security** fixes for
"[spring4shell](https://security.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2436751)"
- bouncy castle was added so that the pop
snoopdave merged pull request #112:
URL: https://github.com/apache/roller/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
mbien commented on pull request #114:
URL: https://github.com/apache/roller/pull/114#issuecomment-1002724702
looks like the CodeQL alerts are going to be reset (reported as new issues,
while the old are removed) since the job is started from a different file.
but the aggregation is worki
mbien opened a new pull request #114:
URL: https://github.com/apache/roller/pull/114
followup on https://github.com/apache/roller/pull/113
This is a workaround which ensures that the test reports end up in the
correct workflow.
example:
JUnit reports of:
https://github.c
snoopdave commented on pull request #112:
URL: https://github.com/apache/roller/pull/112#issuecomment-1001742386
Cool. I'm all for it if it makes things easier for folks using Netbeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
mbien commented on pull request #113:
URL: https://github.com/apache/roller/pull/113#issuecomment-1001671302
https://github.com/mikepenz/action-junit-report/issues/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
mbien commented on pull request #113:
URL: https://github.com/apache/roller/pull/113#issuecomment-1001670124
oh haha. It published it in he CodeQL action
https://github.com/apache/roller/actions/runs/1627718912
--
This is an automated message from the Apache Git Service.
To respond to
mbien commented on pull request #113:
URL: https://github.com/apache/roller/pull/113#issuecomment-1001666008
it builds and tests but it didn't upload the test report (it should appear
on the list on the left i think)
https://github.com/apache/roller/actions/runs/1627718913
Don't k
mbien merged pull request #113:
URL: https://github.com/apache/roller/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien commented on pull request #113:
URL: https://github.com/apache/roller/pull/113#issuecomment-1001661717
awesome. I merge it, lets see if everything builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mbien commented on pull request #112:
URL: https://github.com/apache/roller/pull/112#issuecomment-1001653162
> Velocity changes LGTM. Do the Netbeans changes allow you to debug tests in
the IDE?
Its mostly for registering non-standard maven goals. like jetty:run, or the
selenium tes
mbien commented on pull request #113:
URL: https://github.com/apache/roller/pull/113#issuecomment-1001002706
added step for selenium tests (didn't know that geckodriver could run
headless).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mbien commented on pull request #113:
URL: https://github.com/apache/roller/pull/113#issuecomment-1000996443
i think the junit report will start working once the yaml is in master.
should look like this:
https://github.com/mbien/roller/runs/4631232068?check_suite_focus=true
and if som
mbien opened a new pull request #113:
URL: https://github.com/apache/roller/pull/113
- builds/tests on JDK 11 and 17
- uploads junit report
- disabled a failing test for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
mbien opened a new pull request #112:
URL: https://github.com/apache/roller/pull/112
- Apache Rome had a release
- templates should use `$foreach.index` in loops, old `$velocityCount`
isn't working anymore
- another stream was left open
- Registered some maven actions for NetBe
mbien merged pull request #111:
URL: https://github.com/apache/roller/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien merged pull request #110:
URL: https://github.com/apache/roller/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien commented on pull request #110:
URL: https://github.com/apache/roller/pull/110#issuecomment-1000630935
perfect. I changed the containerfile to checkout tags/roller-6.1.0 instead
of master.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
snoopdave commented on pull request #110:
URL: https://github.com/apache/roller/pull/110#issuecomment-1000410331
@mbien I pushed a roller-6.1.0 tag today and cleaned up all the old RC tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mbien commented on pull request #111:
URL: https://github.com/apache/roller/pull/111#issuecomment-198303
@gregh3269 this should fix the issue you mentioned on the dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mbien commented on pull request #110:
URL: https://github.com/apache/roller/pull/110#issuecomment-148169
@snoopdave could we get a roller-6.1.0 tag for the recent release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
mbien opened a new pull request #111:
URL: https://github.com/apache/roller/pull/111
Template model of the search results page always thought the user was not
logged in.
fix is here f1f80002ace0c5983bb4f7437110b4216e62cba9 other commit tries to
improve readability a little bit.
mbien opened a new pull request #110:
URL: https://github.com/apache/roller/pull/110
- fixed urls
- upgraded to jdk17 and latest lib versions
- better signal handling (made sure container stop signal propagates to
tomcat)
i leave this as draft until we have a tag for 6.1
snoopdave merged pull request #109:
URL: https://github.com/apache/roller/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
snoopdave merged pull request #108:
URL: https://github.com/apache/roller/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
mbien opened a new pull request #109:
URL: https://github.com/apache/roller/pull/109
+ minor struts and spring version bump
https://logging.apache.org/log4j/2.x/changes-report.html#a2.17.0
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mbien opened a new pull request #108:
URL: https://github.com/apache/roller/pull/108
static response is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
mbien merged pull request #107:
URL: https://github.com/apache/roller/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien opened a new pull request #107:
URL: https://github.com/apache/roller/pull/107
another log4j2 version bump
- disables JNDI by default
- removes support for msg lookups
https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0
--
This is an automated message f
mbien merged pull request #106:
URL: https://github.com/apache/roller/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien merged pull request #106:
URL: https://github.com/apache/roller/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien closed pull request #104:
URL: https://github.com/apache/roller/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien opened a new pull request #106:
URL: https://github.com/apache/roller/pull/106
highlights:
- log4j 2.15.0 (fixes security vulnerability[1][2])
- lucene 9 (artifact name changed)
- spring security 5.6
- jquery-ui 1.13 via webjar
- other minor version bumps
[1]
mbien merged pull request #100:
URL: https://github.com/apache/roller/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-966101262
excellent, i see the matching author information now.
@silkriver thank you for the contribution and patience. The next PR should
be easier :)
--
This is an automated message
silkriver commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-96593
@mbien ok I tried again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
mbien commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-964884542
@silkriver unfortunately i still see the same email address
```
git fetch origin pull/100/head:chinese_local
git checkout chinese_local
git log
commit 793d5e2d60afda
mbien commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-952290892
@silkriver could you change the email on the commit to the same email you
used on the ICLA?
Feel free to force push to the branch.
--
This is an automated message from the A
adityasharma7 commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-951761437
I am able to find Luo Cheng with email yuqi...@hotmail.com
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
mbien commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-951167191
@adityasharma7 yeah i still can't access those with my apache id. I don't
want to bother the admins too much since its not so important. Can you check if
we can merge this?
--
Thi
silkriver commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-951001153
Just updated my profile to display the public email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
adityasharma7 commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-950573068
@silkriver Could you please share the email address with which you have
signed the ICLA? Also, it would be good if you could set the email in your git
config (though not a re
mbien commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-950193361
@silkriver did everything work fine? I can't find your nickname on the list
https://people.apache.org/committer-index.html
--
This is an automated message from the Apache Git Servi
mbien merged pull request #105:
URL: https://github.com/apache/roller/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien commented on pull request #105:
URL: https://github.com/apache/roller/pull/105#issuecomment-950191829
@snoopdave no worries dave, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mbien opened a new pull request #105:
URL: https://github.com/apache/roller/pull/105
a set of refactorings for better performance or more concise / easier to
read code + minor version dependency updates
most of it was done by using the jackpot code inspection rules found here:
htt
mbien merged pull request #101:
URL: https://github.com/apache/roller/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien merged pull request #103:
URL: https://github.com/apache/roller/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien commented on pull request #104:
URL: https://github.com/apache/roller/pull/104#issuecomment-919713678
hello @DittoTool
i took a quick look, and beside it not compiling:
* 850c7a5 getWeblogHandleLetterMap() can't be changed since it is a public
service and returns an alphabet
DittoTool opened a new pull request #104:
URL: https://github.com/apache/roller/pull/104
Hi,
We find that there are several inefficient usages of Java Collections:
1. The contains method is invoked upon a list object. We recommend replacing
it with a HashSet.
2. There is no
mbien opened a new pull request #103:
URL: https://github.com/apache/roller/pull/103
Small fix. Did not impact functionality, just the way cache keys were
generated.
bug introduced in 7d07a84
--
This is an automated message from the Apache Git Service.
To respond to the message,
mbien commented on pull request #102:
URL: https://github.com/apache/roller/pull/102#issuecomment-917782955
@snoopdave thanks for taking a look. As mentioned in the PR I just manually
closed the two additional CodeQL alerts.
--
This is an automated message from the Apache Git Service.
To
mbien merged pull request #102:
URL: https://github.com/apache/roller/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rol
mbien opened a new pull request #102:
URL: https://github.com/apache/roller/pull/102
todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
mbien opened a new pull request #101:
URL: https://github.com/apache/roller/pull/101
As noticed by Greg Huber on the mailing list, deleting a folder in the media
file view results in a JS error. (although the folder is still deleted)
this fixes it.
--
This is an automated message
mbien merged pull request #97:
URL: https://github.com/apache/roller/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rolle
mbien merged pull request #98:
URL: https://github.com/apache/roller/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rolle
mbien merged pull request #96:
URL: https://github.com/apache/roller/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rolle
mbien commented on pull request #96:
URL: https://github.com/apache/roller/pull/96#issuecomment-894860204
> Works for me. I built and ran on JDK17 and did not notice any problems.
>
> I did notice one error in tests but I think it is fixed in master:
>
> ```
> [ERROR] Errors
mbien merged pull request #94:
URL: https://github.com/apache/roller/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rolle
mbien edited a comment on pull request #97:
URL: https://github.com/apache/roller/pull/97#issuecomment-894356245
> LGTM
you are too fast for me Dave, now its fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mbien commented on pull request #97:
URL: https://github.com/apache/roller/pull/97#issuecomment-894356245
> LGTM
you are too fast for me Dave, now its fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
mbien commented on pull request #97:
URL: https://github.com/apache/roller/pull/97#issuecomment-893061819
just found a bug while writing a blog entry :) I always forget that a
Matcher doesn't like '$'' signs in the input by default. Have to fix this first
- should be easy.
--
This is an
mbien commented on pull request #97:
URL: https://github.com/apache/roller/pull/97#issuecomment-893061819
just found a bug while writing a blog entry :) I always forget that a
Matcher doesn't like '$'' signs in the input by default. Have to fix this first
- should be easy.
--
This is an
silkriver commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-889653531
OK, I have send the documents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mbien commented on pull request #100:
URL: https://github.com/apache/roller/pull/100#issuecomment-889313850
hello @silkriver.
Thank you for the translation. However before you can contribute to an
Apache project you would have to sign the Apache contributor agreement (ICLA)
found here:
mbien merged pull request #99:
URL: https://github.com/apache/roller/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rolle
mbien commented on pull request #99:
URL: https://github.com/apache/roller/pull/99#issuecomment-885491493
lgtm, integrating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
silkriver opened a new pull request #100:
URL: https://github.com/apache/roller/pull/100
Made a full translation of simplified Chinese
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ymaheshwari1 commented on pull request #99:
URL: https://github.com/apache/roller/pull/99#issuecomment-882030135
Hi @mbien I am checking other themes for the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mbien commented on pull request #99:
URL: https://github.com/apache/roller/pull/99#issuecomment-882027301
Hi Yash, have you checked if this can also happen with the other themes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
ymaheshwari1 opened a new pull request #99:
URL: https://github.com/apache/roller/pull/99
Added an if condition to check whether the weblog has a tagline defined or
not and if there is a tagline present then only displaying the tagline.
Before:
Tagline is always displayed.
After:
