Re: Renaming Next Steps

2017-11-06 Thread Harbs
+1 > On Nov 7, 2017, at 7:25 AM, Alex Harui wrote: > > Hi, > > It looks like the feature/rename branches are building. I think it is > time to merge it into develop before moving on to restructuring the builds > so the tests do not cause circular dependencies. > >

Renaming Next Steps

2017-11-06 Thread Alex Harui
Hi, It looks like the feature/rename branches are building. I think it is time to merge it into develop before moving on to restructuring the builds so the tests do not cause circular dependencies. Also, the JSOnly package in feature/rename seems to be working better in FB (other than the issue

Re: Test Beads (was Re: Unit Tests et. al.)

2017-11-06 Thread Alex Harui
On 11/6/17, 2:06 PM, "Harbs" wrote: >Lots of points here. > >I’m not an expert either, but I’ll try to add my 2 cents… > >> My temptation would be to leverage the [Mixin] capability in the >>compiler >> instead of additional/different CSS. Then it is just a command-line

Re: Test Beads (was Re: Unit Tests et. al.)

2017-11-06 Thread Harbs
Lots of points here. I’m not an expert either, but I’ll try to add my 2 cents… > My temptation would be to leverage the [Mixin] capability in the compiler > instead of additional/different CSS. Then it is just a command-line > option to inject a class that gets initialized early and can do

Re: Compiler projects setup and tests

2017-11-06 Thread Piotr Zarzycki
Erik! Sweet! :) Good Luck! On Mon, Nov 6, 2017, 22:29 Harbs wrote: > Sounds awesome! :-) > > Harbs > > > On Nov 6, 2017, at 11:12 PM, Erik de Bruin wrote: > > > > I'll give it another look tomorrow. Don't care all that much about the > > 'compiler'

Re: Compiler projects setup and tests

2017-11-06 Thread Harbs
Sounds awesome! :-) Harbs > On Nov 6, 2017, at 11:12 PM, Erik de Bruin wrote: > > I'll give it another look tomorrow. Don't care all that much about the > 'compiler' failures (yet), and the 'compiler-jx' failures appear to be true > failures, where expected values don't

Re: Compiler projects setup and tests

2017-11-06 Thread Erik de Bruin
I'll give it another look tomorrow. Don't care all that much about the 'compiler' failures (yet), and the 'compiler-jx' failures appear to be true failures, where expected values don't match the actual values. I'm planning on taking the first steps towards as/mxml to WebAssembly (wasm) in the

Re: [Maven] Core module reporting errors

2017-11-06 Thread Piotr Zarzycki
I just did one more look into the code. For example Maven complaining about ObjectMap class in line 81 where it's function called delete - I remember that there were the discussion about that, but what has been done for Ant build in that matter? Piotr On Wed, Nov 1, 2017, 00:12 Piotr Zarzycki

Re: Working on UI Controls styling

2017-11-06 Thread Harbs
+1. > On Nov 6, 2017, at 8:22 PM, Carlos Rovira wrote: > > Hi Harbs, > > If we go with Basic as seems everybody suggest, I think we should not mix > with Express. We can "copy" some Express knowledge, but not make it > dependent, to avoid having a Frankenstein > Basic

Re: Working on UI Controls styling

2017-11-06 Thread Carlos Rovira
Hi Harbs, If we go with Basic as seems everybody suggest, I think we should not mix with Express. We can "copy" some Express knowledge, but not make it dependent, to avoid having a Frankenstein Basic is the core, and from there we have Express and the new stylizable set 2017-11-05 22:01

Re: Compiler projects setup and tests

2017-11-06 Thread Harbs
Passed for me too. > On Nov 6, 2017, at 7:31 PM, Alex Harui wrote: > > The tests all pass for me. Again, I am in the process of refactoring all > of these tests so they don't have dependencies on flex or royale framework > code (or Flash/AIR either). Then hopefully

Re: Compiler projects setup and tests

2017-11-06 Thread Alex Harui
The tests all pass for me. Again, I am in the process of refactoring all of these tests so they don't have dependencies on flex or royale framework code (or Flash/AIR either). Then hopefully it will be easier to get up and running. -Alex On 11/6/17, 7:06 AM, "Erik de Bruin"

Re: Unit Tests et. al.

2017-11-06 Thread Harbs
Yeah. I noticed your commit. I’ll try to be more careful in the future. > On Nov 6, 2017, at 6:57 PM, Alex Harui wrote: > > Please be aware that in Ant, there are two build paths, one if you have > AIR_HOME pointing to an AIR SDK and another for JS Only. If you make

Re: [royale-asjs] branch develop updated: try to fix js-only build

2017-11-06 Thread Harbs
Oops. Sorry about that… > On Nov 6, 2017, at 6:35 PM, aha...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > aharui pushed a commit to branch develop > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git > > > The following commit(s)

Re: Unit Tests et. al.

2017-11-06 Thread Alex Harui
Please be aware that in Ant, there are two build paths, one if you have AIR_HOME pointing to an AIR SDK and another for JS Only. If you make changes to the builds, you might need to test the build both with and without AIR_HOME/PLAYERLGLOBAL_HOME. And look for failures from the CI after you

Re: Currency formatter instanciation issue (was RE: ApplicationComplete event not firing)

2017-11-06 Thread Harbs
Can you post your console output from compiling the app and the contents of the index.html file? > On Nov 6, 2017, at 5:18 PM, Idylog - Nicolas Granon > wrote: > > FlashBuilder 4.7, Win7, Apache Royale 0.9 binaries : file name : > apache.royale-jsonly-0.9.0-bin.zip

RE: Currency formatter instanciation issue (was RE: ApplicationComplete event not firing)

2017-11-06 Thread Idylog - Nicolas Granon
FlashBuilder 4.7, Win7, Apache Royale 0.9 binaries : file name : apache.royale-jsonly-0.9.0-bin.zip downloaded on 10/25/2017. Nicolas Granon > -Message d'origine- > De : Harbs [mailto:harbs.li...@gmail.com] > Envoyé : lundi 6 novembre 2017 16:10 > À : dev@royale.apache.org > Objet :

RE: Currency formatter instanciation issue (was RE: ApplicationComplete event not firing)

2017-11-06 Thread Idylog - Nicolas Granon
No. The frameworks/libs folder is empty. I use js-only binaries and all SWCs are in frameworks/js/libs. This is where the FormattersJS.swc lies (By the way, it is named FormattersJS.swc, not Formatters.swc). In the flex-config.xml, the tag points to js/libs. Nicolas Granon > -Message

Re: Currency formatter instanciation issue (was RE: ApplicationComplete event not firing)

2017-11-06 Thread Harbs
Related: What are you using to build your app? > On Nov 6, 2017, at 5:01 PM, Yishay Weiss wrote: > > Does > > > > %ROYALE_HOME%/frameworks/libs/Formatters.swc exist? > > > > > From: Idylog - Nicolas Granon >

Compiler projects setup and tests

2017-11-06 Thread Erik de Bruin
Hi, I just spent the day wrestling with the setup of the compiler projects in Eclipse. It's been a while, so it took some doing to get most of the tests to run and pass on 'compiler' and 'compiler-js'. A question for the current compiler hackers: do all tests on 'compiler' and 'compiler-js' pass

RE: Currency formatter instanciation issue (was RE: ApplicationComplete event not firing)

2017-11-06 Thread Yishay Weiss
Does %ROYALE_HOME%/frameworks/libs/Formatters.swc exist? From: Idylog - Nicolas Granon Sent: Monday, November 6, 2017 4:27:22 PM To: dev@royale.apache.org Subject: Currency formatter instanciation issue (was RE: ApplicationComplete event

Currency formatter instanciation issue (was RE: ApplicationComplete event not firing)

2017-11-06 Thread Idylog - Nicolas Granon
No, declaring the formatter in a tag doesn't work either... Execution is stopped after preinitialize event fires. Initialize and applicationComplete events never fire. (I presume that a declaration tag is processed at initialize step ?). (Thank you for the link to the examples repo !) Nicolas

RE: ApplicationComplete event not firing

2017-11-06 Thread Yishay Weiss
Can’t see anything wrong with what you’ve given us. Does this [1] run for you? BTW, feel free to post examples of problems (or successful runs) on that [1] repo. [1] https://github.com/yishayw/Examples/blob/CurrencyFormatter/Examples.mxml From: Idylog -

RE: ApplicationComplete event not firing

2017-11-06 Thread Idylog - Nicolas Granon
You are right ! It does fire...unless some "silent" error happens while building the initial view ! We found that there was an error in the listener for the inner view "initComplete" event. This "inner error" prevents the applicationComplete to fire. But we do not understand why this error

Re: ApplicationComplete event not firing

2017-11-06 Thread Harbs
We are using applicationComplete and it definitely fires. If you post some code maybe I’d have some input. The event type for most events in Royale is Event. Some events have a payload and they have a different event type (such as ValueEvent), but events in Royale are much more generalized

source-map compiler argument : path to source

2017-11-06 Thread Idylog - Nicolas Granon
It appears that, when generating the source map for debugging js output, the path to the source file ("sources" property) is using a relative path. Since it is possible (and often desirable) to send the output outside the workspace/project folder (with js-output argument) it seems to me that the

ApplicationComplete event not firing

2017-11-06 Thread Idylog - Nicolas Granon
(maybe this is not the right place for this kind of message ? let me know) When running our (almost) Hello world application (JS target) it seems that "applicationComplete" event does not fire. "preinitialize" and "initialize" events both fire. The application "viewChanged" event does not fire

Re: Unit Tests et. al.

2017-11-06 Thread Piotr Zarzycki
Hi Harbs, Can you raise for me github issue for Maven, since you have merged and we are going to proceed on develop I prefer have it. Piotr 2017-11-06 10:42 GMT+01:00 Harbs : > Well, Josh reversed the order of the arguments, and I think that makes > sense. The string is

Re: Unit Tests et. al.

2017-11-06 Thread Harbs
Well, Josh reversed the order of the arguments, and I think that makes sense. The string is optional and it was at the beginning. It’s now the optional last argument and all the arguments are as typed as they can be. (compare arguments are of type Object.) I just merged the testing branch into

Re: Working on UI Controls styling

2017-11-06 Thread Harbs
I creates the element structure that Topcoat expects and adds APIs to set the correct CSS class names. From what I recall, the structure for style-able checkboxes is pretty standard across css frameworks, but it probably pays to do some research on the topic before making assumptions. If