Jenkins build is back to normal : royale-asjs_MXTests #252

2018-12-11 Thread apacheroyaleci
See

Build failed in Jenkins: royale-asjs_MXTests #251

2018-12-11 Thread apacheroyaleci
See -- [...truncated 2.36 MB...] [mxmlc] using source file:

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
FWIW, I found one way to force the minifier to not rename a property, which is to create a getter of that name. I tried creating other object structures but they didn't work. So the implementation I am testing right now is that Module and ModuleLoader have these extra getters to guarantee

Re: Some questions about Jewel Navigation

2018-12-11 Thread Piotr Zarzycki
Carlos, I just looked into the problem with double call of change event. You are using as default ListSingleSelectionMouseController - in navigation component which is calling "change" event once someone is clicking on item. However you are doing it again from ArrayListSelectionModel which

Re: [RESULT][VOTE] Release Apache Royale 0.9.4 RC2

2018-12-11 Thread Carlos Rovira
Hi website update is now complete El mar., 11 dic. 2018 a las 23:06, Carlos Rovira () escribió: > Hi > > just make a page on GitHub to document how to publish website changes, so > others can do this. > Since there's is some find and replacement operations needed, that I put > in this mailing

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
ROYALE_CLASS_INFO is a dynamic object. There is no class definition for it, which means that its field names can be renamed. The whole point of modules is to load classes that aren't in the main app so that the main app loads faster. So, if you have MainApp.mxml MyModule.mxml The

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
I’m still not getting the connection to ROYALE_CLASS_INFO. Can you explain to me in pseudo-code the problem with that? Why does a dynamic object have ROYALE_CLASS_INFO at all? > On Dec 12, 2018, at 12:16 AM, Alex Harui wrote: > > I'm not sure why you think it is theoretical. For sure, in

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
I'm not sure why you think it is theoretical. For sure, in TDF, the module is not loading because ROYALE_CLASS_INFO is minified differently in the main app than the module. Any dynamic objects shared across compilations are at risk of being renamed differently. I'm chasing down a way to

Re: [RESULT][VOTE] Release Apache Royale 0.9.4 RC2

2018-12-11 Thread Carlos Rovira
Hi just make a page on GitHub to document how to publish website changes, so others can do this. Since there's is some find and replacement operations needed, that I put in this mailing list, but are hard to find I think this was needed. Athough I think I'll continue updating the website, is

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
Hi Carlos, We’re only discussing dynamic objects. How many of those do you have in your applications? I doubt there’s much difference in performance due to minification of dynamic objects. In *all* our framework code we have dynamic object instantiation in 435 places including TLF, Spark and

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Carlos Rovira
Hi, I'm still not using modules. I left that for now until we complete the first phase in our project, but will be using (hopefully) around February. So right now we're only using minification, that seems not only to reduce the size of the build, but release mode performs faster, and I think is

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
I’m pretty sure that any names which are a single character (or I think two characters), will not be renamed by the google compiler. > On Dec 11, 2018, at 11:19 PM, Frost, Andrew wrote: > > So I think what you're saying is that the full build process will result in a > minified JS file where

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
Shouldn’t we try an avoid use of dynamic objects in framework code? > On Dec 11, 2018, at 10:23 PM, Alex Harui wrote: > > Thinking about it more, -js-dynamic-access probably won't help. We don't > want to compile our SWCs with that option on and thus turn off minification > of these field

Re: Some questions about Jewel Navigation

2018-12-11 Thread Carlos Rovira
Hi Piotr, but .nav will not do anything. As I write before the right things should be .jewel.navigation background-color: transparent This in you App css will win over the one in the theme. Didn't try, but that should work, at least is what I do when I want some quick change to try or

Re: Some questions about Jewel Navigation

2018-12-11 Thread Piotr Zarzycki
I have tried to do point #2 from your options, but when I declare my own class: .nav { background-color: #ff } It's being override by those one from framework. Maybe I have to inherited from framework classes ? Thanks, Piotr wt., 11 gru 2018 o 20:44 Carlos Rovira napisał(a): > Hi Piotr,

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
Thinking about it more, -js-dynamic-access probably won't help. We don't want to compile our SWCs with that option on and thus turn off minification of these field names always if we can help it. Even a directive per occurrence won't help either. Whether a field name is renamed is still

Re: Some questions about Jewel Navigation

2018-12-11 Thread Carlos Rovira
Hi Piotr, El mar., 11 dic. 2018 a las 17:37, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > Hi Carlos, > > I have started playing using Jewel lately more serious and have two > questions related to Jewel Navigation component. > > I'm displaying horizontal navigation like that [1].

Re: [RESULT][VOTE] Release Apache Royale 0.9.4 RC2

2018-12-11 Thread Carlos Rovira
Hi Andrew, the source code is JewelExample here: https://github.com/apache/royale-asjs/tree/develop/examples/royale/JewelExample as well if you go to the Alert part, you'll see a tab navigator (still in development so a bit ugly yet), with a tab with the example and other that points to the

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
I vote for A. We can also do B which would require manually changing all access to brackets and quote all names in object literals. I might be nice to add some comment decorations to enable/disable -js-dynamic-access on a case-by-case basis, but I think it’s reasonable to have a global on/off

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
IMO, some folks will want to rely on minification of object field names so save space. I think -js-dynamic-access blocks minification. So, to try to pose the problem another way, you can rely on minification object field names if you are building a single-js-file app, but as soon as you start

Re: [RESULT][VOTE] Release Apache Royale 0.9.4 RC2

2018-12-11 Thread Andrew Wetmore
This is fun to play with! Where is the source code for each example? On Tue, Dec 11, 2018 at 2:16 PM Carlos Rovira wrote: > Hi all > > updates to the website are live. Although I saw there's still some few > little issues, that I'll solve more later since I must to left right now. > > I added

Re: js-only not working

2018-12-11 Thread Alex Harui
On 12/11/18, 9:26 AM, "Harbs" wrote: Yes. I built using main with no env.AIR_HOME. What changed that makes this fail? The listing of all SWCs except MXRoyale/SparkRoyale in royale-config.xml in order to resolve the default CSS problem. It used to be a wildcard, so it didn't

Re: [RESULT][VOTE] Release Apache Royale 0.9.4 RC2

2018-12-11 Thread Carlos Rovira
Just one more thing :) if you see something in r.a.o let me know so I can fix all that in the fixes I'll do in few hours thanks! Carlos El mar., 11 dic. 2018 a las 19:16, Carlos Rovira () escribió: > Hi all > > updates to the website are live. Although I saw there's still some few > little

Re: [RESULT][VOTE] Release Apache Royale 0.9.4 RC2

2018-12-11 Thread Carlos Rovira
Hi all updates to the website are live. Although I saw there's still some few little issues, that I'll solve more later since I must to left right now. I added Jewel Example as "Tour de Jewel" in "Home" and "Feature" pages, so this points to: http://royale.apache.org/tourdejewel/ More to share

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
I’m not following why this is the same point. I’m using -js-dynamic-access-unknown-members=true to handle this kind of problem. It works flawlessly… I’d personally argue that true should be the default, but whether the default is true or not, we do have an option to deal with these kinds of

Re: js-only not working

2018-12-11 Thread Harbs
Yes. I built using main with no env.AIR_HOME. What changed that makes this fail? > On Dec 11, 2018, at 6:31 PM, Alex Harui wrote: > > Did you build it by running the Ant "main" target without env.AIR_HOME or did > you use with "release" target with env.AIR_HOME? I think nobody has tried >

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
Yes, we can use our own short names in code we generate, but that's not really the point. The point is that any plain object field can be renamed based on other code in the compile. So if you just have: Var obj:Object = { harbs: 1}; Public static function foo() { Trace(obj.harbs); } Use

Some questions about Jewel Navigation

2018-12-11 Thread Piotr Zarzycki
Hi Carlos, I have started playing using Jewel lately more serious and have two questions related to Jewel Navigation component. I'm displaying horizontal navigation like that [1]. Because Navigation is actually list my background color is white. The question is how to make my navigation

Re: js-only not working

2018-12-11 Thread Alex Harui
Did you build it by running the Ant "main" target without env.AIR_HOME or did you use with "release" target with env.AIR_HOME? I think nobody has tried "main" yet and that will need some adjusting. The latter should work because that's what the CI server uses. From just quickly looking at

Re: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Harbs
I was about to make the same suggestion. We can use “I” for interfaces, “c” for class, “k” for kind, “n” for names. etc. > On Dec 11, 2018, at 2:52 PM, Frost, Andrew wrote: > > Hi > > Not sure that I fully understand this but would a valid compromise be > something where the field name isn't

Jenkins build is back to normal : royale-asjs_MXTests #250

2018-12-11 Thread apacheroyaleci
See

RE: ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Frost, Andrew
Hi Not sure that I fully understand this but would a valid compromise be something where the field name isn't renamed at all automatically, but we just change it in the JS generation code to be "i" rather than "interfaces", and update the Language is/as functions to work with this property

js-only not working

2018-12-11 Thread Harbs
I just built a js-only build of Royale and it seems like something is expecting the SWF swcs to be there even thought the target is JSRoyale: MXMLJSC +royalelib=c:\Users\shifa\Documents\Apache\royale-asjs\frameworks --debug=true +configname=royale --targets=JSRoyale --source-map=true

ROYALE_CLASS_INFO, renaming, modules, Objects

2018-12-11 Thread Alex Harui
I spent some time today trying to get Tour De Flex to run in production mode with the main app and modules being separately minified. I've fixed a few things here and there, but an interesting issue I ran into has to do with the plain object we use in ROYALE_CLASS_INFO (and will apply to other

RE: Dependency Missing

2018-12-11 Thread Yishay Weiss
>The dependency you posted below indicates that it is one of your files, which >must be being used by another one of your files, so the question is whether >the file that couldn't find that dependency is in your source >path or is >coming from a SWC that was compiled earlier. It was coming

Build failed in Jenkins: royale-asjs_MXTests #249

2018-12-11 Thread apacheroyaleci
See Changes: [greg.dove] Fix for including null in the parameters for a service call when using -- [...truncated 2.42 MB...] [mxmlc]