Re: [royale-asjs] 02/02: Cumulative updates to migrate to 'selectionChanged' for bindings Fixes a some issues with add/remove/update beads for dataprovider/item changes. Added extra test display to To

2018-12-20 Thread Greg Dove
The main purpose for that is to avoid using the model itself as the dispatcher. It could still extend EventDispatcher, but the methods would still need overriding to use the host component as the dispatcher instead of 'this'. By using the host component as the primary dispatcher, it avoids

Re: DragEvent.clientY

2018-12-20 Thread Harbs
When I looked at the class, I didn’t understand why it didn’t *actually* subclass MouseEvent. What’s the purpose of DragEventBase? > On Dec 21, 2018, at 9:01 AM, Alex Harui wrote: > > Ah, ok, I didn't notice the IFrame. The goal is to have DragEvent appear to > subclass MouseEvent, so

Re: [royale-asjs] 02/02: Cumulative updates to migrate to 'selectionChanged' for bindings Fixes a some issues with add/remove/update beads for dataprovider/item changes. Added extra test display to To

2018-12-20 Thread Alex Harui
Looks reasonable. Can you explain why ArrayListSelectionModel should not extend EventDispatcher and encapsulate one instead? Isn't encapsulation more code to run? -Alex On 12/20/18, 10:26 PM, "gregd...@apache.org" wrote: This is an automated email from the ASF dual-hosted git

Re: DragEvent.clientY

2018-12-20 Thread Alex Harui
Ah, ok, I didn't notice the IFrame. The goal is to have DragEvent appear to subclass MouseEvent, so whatever values a MouseEvent would have, the DragEvent should have. Thanks, -Alex On 12/20/18, 11:23 AM, "Harbs" wrote: > I think clientX/Y does depend on the target. In the link [2],

Build failed in Jenkins: royale-asjs #1724

2018-12-20 Thread apacheroyaleci
See -- [...truncated 2.14 MB...] [java] [java]

Re: DragEvent.clientY

2018-12-20 Thread Harbs
> I think clientX/Y does depend on the target. In the link [2], there is an > example that you can play with, and clientX/Y is not global coordinates. MDN > is usually good doc, but I think the doc for clientX/Y is not well-written. It does not depend on the target. It’s global relative to

Re: DragEvent.clientY

2018-12-20 Thread Alex Harui
I think clientX/Y does depend on the target. In the link [2], there is an example that you can play with, and clientX/Y is not global coordinates. MDN is usually good doc, but I think the doc for clientX/Y is not well-written. -Alex On 12/20/18, 5:48 AM, "Yishay Weiss" wrote:

Jenkins build is back to normal : royale-asjs_MXTests #286

2018-12-20 Thread apacheroyaleci
See

RE: DragEvent.clientY

2018-12-20 Thread Yishay Weiss
Actually, creating localX/localY in HTML is expensive so maybe not a PAYG solution. I suggest to just have clientX/Y mirror the mouse event and let listeners figure out what they need similar to what I did here [1]. Thoughts? [1]

RE: DragEvent.clientY

2018-12-20 Thread Yishay Weiss
The only place [1] in Flex code I see a similar logic is in DragProxy, where a change of targets transforms the localX/Y values. But I was referring to clientX/Y which should not depend on the target. As I understand [2] it, is just the position of the pointer in the browser window. It

Build failed in Jenkins: royale-asjs_MXTests #285

2018-12-20 Thread apacheroyaleci
See -- [...truncated 2.41 MB...] [mxmlc] using source file:

Jenkins build is back to normal : royale-asjs_jsonly #2082

2018-12-20 Thread apacheroyaleci
See

Re: Need to clean

2018-12-20 Thread Alex Harui
OK, I will look into it tomorrow. I realize now that the Ant scripts build twice (debug then release) so I was always getting a second compile. -Alex On 12/20/18, 1:40 AM, "Harbs" wrote: TourDeJewel has similar results to my app. There are a number of classes which have

Re: How to discover programmatic change in Jewel List

2018-12-20 Thread Piotr Zarzycki
Hi Greg, Great news, cause I was going to look into that somewhere between Christmas and New Year. I would be happy to test your changes! Do not hesitate push it! Thank you so much! Piotr czw., 20 gru 2018 o 10:39 Greg Dove napisał(a): > Piotr, Alex, > > fyi I found some time to spend on this

Re: Need to clean

2018-12-20 Thread Harbs
TourDeJewel has similar results to my app. There are a number of classes which have different requires: ButtonPlayground ListPlayGround SliderPlayGround SnackbarPlayGround TablePlayGround WizardPlayGround The first compile seems to have requires which are removed on the second compile. It’s

Re: How to discover programmatic change in Jewel List

2018-12-20 Thread Greg Dove
Piotr, Alex, fyi I found some time to spend on this today, and Piotr, I should be ready to push the changes I made to your branch tomorrow morning my time (local time - GMT+13). It seems to be fine so far with 'selectionChange' for binding based on model changes and 'change' for class event meta.

Re: Need to clean

2018-12-20 Thread Harbs
The class has these lines which likely complicate things: /** * @export * @type {org.apache.royale.collections.ArrayList} */ com.printui.view.managers.LocaleManager.spellingLocalesList_ = new org.apache.royale.collections.ArrayList(); The above was generated from: [Bindable] public static

Re: Need to clean

2018-12-20 Thread Harbs
I was not clear below that the ArrayList dependency was a static one. > On Dec 20, 2018, at 10:58 AM, Harbs wrote: > > Using my app: > > First blush looks good. I don’t get any compile errors. > > Second blush reveals that the files are not identical. > > Interestingly: > > I have one class

Re: Need to clean

2018-12-20 Thread Harbs
Using my app: First blush looks good. I don’t get any compile errors. Second blush reveals that the files are not identical. Interestingly: I have one class which has a single Royale dependency: ArrayList. A double-compile results in: goog.require('org.apache.royale.collections.ArrayList');

Jenkins build is back to normal : royale-compiler #630

2018-12-20 Thread apacheroyaleci
See