Re: [royale-compiler] branch develop updated: compiler: added support for abstract classes in ActionScript

We could have a whole discussion about what the recommended Singleton pattern should be. IMO, it should either be a SingletonManager/Locator, or require two classes, a Manager and an Impl. There are some folks from Flex who felt that simple Singletons (a class with static methods) prevented mo

Jenkins build is back to normal : royale-asjs_MXTests #409

See

Build failed in Jenkins: royale-asjs_MXTests #408

See -- [...truncated 2.09 MB...] [mxmlc] c:/jenkins/workspace/royale-asjs_MXTests/mustella/tests/mxtests/basicTests/bin/js-debug/org/apache/royale/core

Re: [royale-compiler] branch develop updated: compiler: added support for abstract classes in ActionScript

Oh! I was wondering why Alex brought that up. It seemed way out of left field to me, since no one in the thread had been talking about static-method-only classes. I didn't think to look in the commits. - Josh On 2019/01/26 16:41:56, Harbs wrote: > OK. I’ll revert that change. > > I like the

Re: [royale-compiler] branch develop updated: compiler: added support for abstract classes in ActionScript

OK. I’ll revert that change. I like the idea of private constructors. That does make more sense than making the class abstract. Singletons was one of the areas that I was wondering how we could improve, and this sounds like a great proposal. Thanks, Harbs > On Jan 25, 2019, at 8:17 PM, Josh Ty

Jenkins build is back to normal : royale-asjs_MXTests #406

See

Re: [royale-asjs] branch develop updated: Jewel Group: Fix dynamic adding Horizontal/Vertical layout

Ok! Raise an issue if you don't have time to look into that, so we won't forget. I can also revert it and will add fix in my own code. sob., 26 sty 2019 o 15:39 Carlos Rovira napisał(a): > Hi Piotr, > > this seems not a proper fix for me. Why Simple*** should be responsible of > removing selecto

Re: [royale-asjs] branch develop updated: Jewel Group: Fix dynamic adding Horizontal/Vertical layout

Hi Piotr, this seems not a proper fix for me. Why Simple*** should be responsible of removing selectors of BasicLayout?, and what if instead of the current classes will be others with other selectors? The fix should be something where a bead setup its own selectors when added and responsible to r

Re: Vertical FormItem

You're right, the "transfer" thing come from Basic Panel, and I think that code is not working even in Basic, but I didn't clean it. So yours seems more clean. If it works (example continue working as before) commit that and we see if we found some eventual regression thanks El sáb., 26 ene. 201

Build failed in Jenkins: royale-asjs_MXTests #405

See Changes: [piotrzarzycki21] Jewel Group: Fix dynamic adding Horizontal/Vertical layout -- [...truncated 2.02 MB...] [mxmlc] using sour

Jenkins build is back to normal : royale-asjs #1855

See

Re: Vertical FormItem

In my opinion this part should looks like that: https://paste.apache.org/gbn2 - Simple initialization. If someone would like to use anything more than default (currently it's IFormItemContentArea: ClassReference("org.apache.royale.jewel.Group"); ) - He can use it - for example HGroup. What do you

Build failed in Jenkins: royale-asjs #1854

frameworks/projects/*/src/main/royale> clean: super-clean: [delete] Deleting directory <http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs/ws/frameworks/themes/Spark> create-description: [echo] build.number is 20190126 js-output-royale-description:

Re: Compiler build is failing - Ant

Great guys! Many Thanks for help - It looks like wipe-all did the job for me! sob., 26 sty 2019 o 12:17 Carlos Rovira napisał(a): > Hi Piotr, > > just build it about an hour or so. In my build script (Mac) I have for the > compiler part: > > ant wipe-all > mvn clean install -DskipTests --quiet

Re: Vertical FormItem

Carlos, I think I got it. It looks like we don't need IFormItemLayout as you said, cause I should be able to manipulate content of my FormItem by doing that: IBeadLayout: ClassReference("org.apache.royale.jewel.beads.layouts.HorizontalLayout"); IFormItemContentArea: ClassReference("org.apache.roy

Jenkins build is back to normal : royale-asjs_MXTests #404

See

Re: Vertical FormItem

Remember I'm talking above only about contentArea of FormItem. sob., 26 sty 2019 o 12:57 Piotr Zarzycki napisał(a): > Carlos, > > I think I got it. It looks like we don't need IFormItemLayout as you said, > cause I should be able to manipulate content of my FormItem by doing that: > > IBeadLayou

Re: Jewel Group layout change dynamically (was: Re: Vertical FormItem)

I must to leave now, at this time can't give you an answer. If you see a clear place where this could be fixed we can try it. thanks El sáb., 26 ene. 2019 a las 12:11, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > Fix probably should be placed in SimpleVerticalLayout in beadsAddedHan

Re: Jewel Group layout change dynamically (was: Re: Vertical FormItem)

Right!, so "basic" is from "BasicLayout", and there's a bug somewhere that is not removing that selector. I think the problem is that in the mxml declaration, Royale never tries to assign a BasicLayout and goes directly with the new one. Instead, in the other way it adds BasicLayout, and then the o

Re: Vertical FormItem

Piotr, I think I don't think we need and IFormItemLayout. IBeadLayout seems sufficient for me, since that layout will be based just on css selectors that are in the end what solves the layout El sáb., 26 ene. 2019 a las 12:00, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > Too bad that

Re: Compiler build is failing - Ant

Hi Piotr, just build it about an hour or so. In my build script (Mac) I have for the compiler part: ant wipe-all mvn clean install -DskipTests --quiet to ensure compiler is cleaned before building with maven (my script ends doing a full SDK build with ANT) best Carlos El vie., 25 ene. 2019

Re: Jewel Group layout change dynamically (was: Re: Vertical FormItem)

Fix probably should be placed in SimpleVerticalLayout in beadsAddedHandler sob., 26 sty 2019 o 12:09 Piotr Zarzycki napisał(a): > Carlos, > > This is html output when you add Vertical layout dynamically -> > https://imgur.com/7MhKEyS - basic is not needed yes ? > > Thanks, > Piotr > > sob., 26 s

Re: Jewel Group layout change dynamically (was: Re: Vertical FormItem)

Carlos, This is html output when you add Vertical layout dynamically -> https://imgur.com/7MhKEyS - basic is not needed yes ? Thanks, Piotr sob., 26 sty 2019 o 12:06 Carlos Rovira napisał(a): > Changing subject since this seems not related to FormItem right? > > to see what's happening and und

Build failed in Jenkins: royale-asjs_MXTests #403

See Changes: [piotrzarzycki21] FormItemView: Make some fields protected so it could be usable when -- [...truncated 2.01 MB...] [mxmlc]

Jewel Group layout change dynamically (was: Re: Vertical FormItem)

Changing subject since this seems not related to FormItem right? to see what's happening and understand the problem and find a solution we should look at: * generated HTML: since all in Jewel is CSS based, what is the html output? The way I think Royale works (for Basic, Jewel,..), is that addin

Re: Vertical FormItem

Too bad that you didn't understand me. Just question to above requirements - What in your opinion should do layout added trough -> *IFormItemLayout ?* sob., 26 sty 2019 o 11:54 Carlos Rovira napisał(a): > Hi Piotr, > > Don't think if I understand right your exposition. I'll try to write in > wo

Re: Vertical FormItem

ForItem is based on Basic Panel work since we have "chrome" elements and "content" elements. don't remember exactly but I found that in Panel changes to bead layout was not working as expected, so all this can be part of that problem El vie., 25 ene. 2019 a las 17:17, Piotr Zarzycki (< piotrzarzyc

Re: Vertical FormItem

Hi Piotr, Don't think if I understand right your exposition. I'll try to write in words what I expect from a FormItemLayout and let me know if we're thinking on the same. We want to have a specialized layout for FormItem that support horizontal and stacked form item layouts. At this point we can

Re: Vertical FormItem

Carlos, I discovered also one more bug or at least I'm thinking about that as a bug. Having following code [1] does work, but if I add bead dynamically - it doesn't work. [2] - I believe fix can be placed in method beadsAddedHandler - Do you think this is a bug and fix can be here ? [1] https://p