Re: Release Step 001 Succeeded

2019-02-19 Thread Alex Harui
Note to self: Installed custom maven-scm-provider.jgit jar per https://issues.apache.org/jira/browse/SCM-921 On 2/19/19, 9:28 PM, "Apache Royale CI Server" wrote: Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_001 and run the

Royale_Release_Step_002 - Build # 12 - Failure!

2019-02-19 Thread Apache Royale CI Server
Royale_Release_Step_002 - Build # 12 - Failure: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_002/12/ to view the results.

Release Step 001 Succeeded

2019-02-19 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_001 and run the following commands: git push git checkout release/0.9.6 git push -u origin release/0.9.6 You will need your Apache/Github username and 2FA token.

Build failed in Jenkins: royale-asjs_MXTests #513

2019-02-19 Thread Apache Royale CI Server
See -- [...truncated 2.02 MB...] [mxmlc] using source file:

Build failed in Jenkins: TourDeFlexMigration #531

2019-02-19 Thread Apache Royale CI Server
See -- [...truncated 3.73 MB...] [mxmlc] using SWC: C:\jenkins\workspace\royale-asjs\frameworks\js\libs\BindingJS.swc [mxmlc] using SWC:

Jenkins build is back to normal : royale-asjs_MXTests #512

2019-02-19 Thread Apache Royale CI Server
See

Build failed in Jenkins: royale-asjs_MXTests #511

2019-02-19 Thread Apache Royale CI Server
See Changes: [carlosrovira] BrowserOrientation bead to get device orientation (portrait or [carlosrovira] TDJ BrowserOrientation bead example of use [carlosrovira] fix

Re: Breaking Compiler Change

2019-02-19 Thread Josh Tynjala
Here is where it is defined in Royale: https://github.com/apache/royale-asjs/blob/e02f896f3510a90aff00d852dac4401e2705fcf3/frameworks/projects/XML/src/main/royale/XML.as#L2767 It does not exist in Flash. I'm trying to determine why it exists in Royale and if it's still necessary. - Josh On

Jenkins build is back to normal : royale-asjs #1970

2019-02-19 Thread Apache Royale CI Server
See

Re: Breaking Compiler Change

2019-02-19 Thread Alex Harui
I'm confused. Where is the ASDoc for XML.split? On 2/19/19, 2:41 PM, "Josh Tynjala" wrote: I was just playing around with XML in Flash, and I tried this code: var xml:XML = ; var parts:Array = xml.split("/"); It compiles, but I get the following runtime error:

Re: Breaking Compiler Change

2019-02-19 Thread Josh Tynjala
I was just playing around with XML in Flash, and I tried this code: var xml:XML = ; var parts:Array = xml.split("/"); It compiles, but I get the following runtime error: > TypeError: Error #1006: value is not a function. To work in Flash, I need to assign the XML instance to a String first so

Jenkins build is back to normal : royale-asjs_jsonly #2488

2019-02-19 Thread Apache Royale CI Server
See

Jenkins build is back to normal : royale-typedefs #1123

2019-02-19 Thread Apache Royale CI Server
See

Jenkins build is back to normal : royale-compiler #733

2019-02-19 Thread Apache Royale CI Server
See

Re: [royale-compiler] 05/05: ParametersEmitter: fixed automatic type coercion and added some tests (closes #74)

2019-02-19 Thread Josh Tynjala
I meant that this comment is exactly the substance that I was looking for. - Josh On 2019/02/19 20:59:30, Alex Harui wrote: > What kind of substance are you looking for? Did you see the isXMLIsh() code? > > -Alex > > On 2/19/19, 12:08 PM, "Josh Tynjala" wrote: > > I discovered the

Re: Breaking Compiler Change

2019-02-19 Thread Alex Harui
FWIW, I'm not sure I've followed this, but it may help to mention that, IMO, Closure has started to strictly-type the externs for the browser APIs. Which may be undesirable for some folks. So one option is to create an alternative to JS.swc which does have more "*"s in the APIs. HTH, -Alex

Re: [royale-compiler] 05/05: ParametersEmitter: fixed automatic type coercion and added some tests (closes #74)

2019-02-19 Thread Alex Harui
What kind of substance are you looking for? Did you see the isXMLIsh() code? -Alex On 2/19/19, 12:08 PM, "Josh Tynjala" wrote: I discovered the following comment in IdentifierNode.resolveMemberRef(): // If the base type is XML or XMLList, // don't resolve a member reference

Build failed in Jenkins: royale-asjs_jsonly #2487

2019-02-19 Thread Apache Royale CI Server
See Changes: [carlosrovira] remove some warnings [carlosrovira] decorate labels in itemrenders when using filter beads to show the --

Re: [royale-compiler] 05/05: ParametersEmitter: fixed automatic type coercion and added some tests (closes #74)

2019-02-19 Thread Josh Tynjala
I discovered the following comment in IdentifierNode.resolveMemberRef(): // If the base type is XML or XMLList, // don't resolve a member reference to any definition. // As in the old compiler, this avoids possibly bogus // -strict type-coercion errors. // For example, we don't

Re: Breaking Compiler Change

2019-02-19 Thread Josh Tynjala
In the Closure compiler externs, it's an optional number: @param {number=} opt_limit In pure JS, that technically allows you to pass in both undefined or a number, but I think that the fact that undefined is not included directly also signals a certain intent for it to be stricter. However, it

Re: Breaking Compiler Change

2019-02-19 Thread Harbs
The methods in XML are there to allow XML to behave as if it’s a String or a Number. In JS, the signature of split is "undefined|Number". That becomes “*” in AS3 considering AS3 does not have “dual” types. > On Feb 19, 2019, at 8:59 PM, Josh Tynjala wrote: > > My gut feeling would be to

Re: Breaking Compiler Change

2019-02-19 Thread Josh Tynjala
My gut feeling would be to strive for consistency in how the automatic type conversion behaves. If some function calls have it, and others don't, that's potentially confusing. Someone used to AS3 behavior might expect undefined to become NaN, and they'll wonder why it didn't happen in one place

Re: Breaking Compiler Change

2019-02-19 Thread Harbs
I did not mean that Number(undefined) shouldn’t become NaN. That’s correct behavior. I was questioning the coercion here. I already changed XML to used bracketed access for this problem. I’m not thrilled about passing in a number to split. My gut tells me that it’s probably slower than

Re: Problems dealing with bead substitution in Royale

2019-02-19 Thread Harbs
> On Feb 19, 2019, at 5:14 PM, Carlos Rovira wrote: > > Hi Harbs, > > I finally could take a look at you notification system, I can intuit a > good idea but still need more info or explanation from you to get the > benefits. My questions is more about the global thinking of the > notification

Build failed in Jenkins: royale-compiler #732

2019-02-19 Thread Apache Royale CI Server
See Changes: [joshtynjala] compiler: DynamicAccessNode resolves element type of Vector (closes #80) -- [...truncated 1.03 KB...]

Re: [royale-compiler] 05/05: ParametersEmitter: fixed automatic type coercion and added some tests (closes #74)

2019-02-19 Thread Josh Tynjala
I'm not exactly sure what you'd like me to check in SWF output. Can you add some more detail? - Josh On 2019/02/19 16:37:04, Alex Harui wrote: > For #1, did you test using SWF output? There's a small chance it will do > more checks than the JS output. > > -Alex > > On 2/19/19, 8:03 AM,

Re: [royale-compiler] 05/05: ParametersEmitter: fixed automatic type coercion and added some tests (closes #74)

2019-02-19 Thread Alex Harui
For #1, did you test using SWF output? There's a small chance it will do more checks than the JS output. -Alex On 2/19/19, 8:03 AM, "Josh Tynjala" wrote: 1. b.moveTo(Number(path.pathPoints[0].anchor.x), Number(path.pathPoints[0].anchor.y)); I have determined that the compiler

Re: [royale-compiler] 05/05: ParametersEmitter: fixed automatic type coercion and added some tests (closes #74)

2019-02-19 Thread Josh Tynjala
1. b.moveTo(Number(path.pathPoints[0].anchor.x), Number(path.pathPoints[0].anchor.y)); I have determined that the compiler is not correctly resolving the type of pathPoints[0]. It should be PathPointVO because we're dealing with a Vector, but it's being resolved as * instead, which is how

Build failed in Jenkins: royale-asjs_jsonly #2486

2019-02-19 Thread Apache Royale CI Server
See Changes: [carlosrovira] searchfilterforlist bead: select the item in the list (or in the -- [...truncated 204.08 KB...] [echo]

Re: Breaking Compiler Change

2019-02-19 Thread Josh Tynjala
I tested the following code in Flash: var num:Number = undefined; trace(num); //NaN Assigning undefined to a Number results in NaN in Flash. The XML signature for split() should probably look like this instead: split(delimiter:* = undefined, limit:Number = 0x7fff):Array It looks like

Re: Problems dealing with bead substitution in Royale

2019-02-19 Thread Carlos Rovira
Hi Harbs, I finally could take a look at you notification system, I can intuit a good idea but still need more info or explanation from you to get the benefits. My questions is more about the global thinking of the notification idea more than an implementation question: 1.- why we have tow

Build failed in Jenkins: royale-asjs #1969

2019-02-19 Thread Apache Royale CI Server
See -- [...truncated 204.98 KB...] [echo] ROYALE_COMPILER_HOME is C:\Program Files (x86)\Jenkins\workspace\royale-compiler\compiler download-other-license:

Build failed in Jenkins: royale-asjs #1968

2019-02-19 Thread Apache Royale CI Server
See Changes: [carlosrovira] searchfilterforlist bead: select the item in the list (or in the -- [...truncated 204.98 KB...] [echo]

Build failed in Jenkins: royale-asjs #1967

2019-02-19 Thread Apache Royale CI Server
See Changes: [carlosrovira] BrowserOrientation bead to get device orientation (portrait or [carlosrovira] TDJ BrowserOrientation bead example of use [carlosrovira] fix BrowserOrientation

Build failed in Jenkins: royale-compiler #731

2019-02-19 Thread Apache Royale CI Server
See -- [...truncated 1.01 KB...] [royale-compiler] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat -file jenkins.xml '"-Denv.ASJS_HOME=C:\Program Files

Re: Problems dealing with bead substitution in Royale

2019-02-19 Thread Harbs
Bump. > On Feb 1, 2019, at 8:36 AM, Harbs wrote: > > https://github.com/apache/royale-asjs/commit/1b2a45c91397e485be93d56925f2c31417726bb7#diff-2b4ced1196f39150a85b0cd61bbb338dL64 > >