Jenkins build is back to normal : royale-asjs_jsonly #2558

2019-03-07 Thread Apache Royale CI Server
See

Re: [TEST2] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Alex Harui
Hi Dave, I added the link to the KEYS file to the vote thread template. Why does it have to be clear who the release manager is? The release will be a decision of the entire PMC. Really, several people can split up running the steps on Jenkins. In an extreme case, a different person could v

Re: [TEST2] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Dave Fisher
The instructions should point to the KEYS file. It should be clear that you, the release manager, is the one providing this release. Signing at the end like a letter is below the fold. Great work! Regards, Dave Sent from my iPhone > On Mar 7, 2019, at 4:36 PM, Apache Royale CI Server > wrot

Re: AMF updates

2019-03-07 Thread Greg Dove
'I thought that even native AS types (int, number, string) essentially had a class alias in the AMF data and thus XML and Dictionary would too.' I expect they probably have actual traits information in the avm implementation for more general purposes and for consistency. But these are treated spec

Re: 0.9.6 Release

2019-03-07 Thread Alex Harui
OK, I've now seen Jenkins perform the steps to build the release artifacts. Folks interested in Docker-izing the steps are welcome to look at the jobs on the "Royale Release" tab on the CI server. http://apacheroyaleci.westus2.cloudapp.azure.com:8080/view/Royale%20Release/ These steps assume t

[TEST2] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Apache Royale CI Server
This is the discussion thread. Thanks, Alex

[TEST] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Apache Royale CI Server
Hi, This is vote for the 0.9.6 release of Apache Royale. The release candidate can be found here; https://dist.apache.org/repos/dist/dev/royale/0.9.6/rc1/ Before voting please review the section,'What are the ASF requirements on approving a release?', at: http://www.apache.org/dev/release.html#a

[TEST2] Release Apache Royale RC

2019-03-07 Thread Apache Royale CI Server
This is the discussion thread. Thanks,

[TEST] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Apache Royale CI Server
Hi, This is vote for the 0.9.6 release of Apache Royale. The release candidate can be found here; https://dist.apache.org/repos/dist/dev/royale/0.9.6/rc1/ Before voting please review the section,'What are the ASF requirements on approving a release?', at: http://www.apache.org/dev/release.html#a

Re: 0.9.6 Release

2019-03-07 Thread Alex Harui
In case you haven't guessed, I'm testing out Jenkins and its ability to create the artifacts and send emails. Please ignore any email that looks like a vote or discuss thread. Thanks, -Alex On 2/10/19, 8:44 PM, "Alex Harui" wrote: Om, Well, that's what I used for the last relea

[TEST2] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Apache Royale CI Server
This is the discussion thread. Thanks, Alex

Re: AMF updates

2019-03-07 Thread Alex Harui
Well, maybe you can answer this one question: I thought that even native AS types (int, number, string) essentially had a class alias in the AMF data and thus XML and Dictionary would too. And then in theory, anyone could change the class alias map to map the alias for XML to something else.

[TEST] Release Apache Royale 0.9.6 RC1

2019-03-07 Thread Apache Royale CI Server
Hi, This is vote for the 0.9.6 release of Apache Royale. The release candidate can be found here; https://dist.apache.org/repos/dist/dev/royale/0.9.6/rc1/ Before voting please review the section,'What are the ASF requirements on approving a release?', at: http://www.apache.org/dev/release.html#a

Re: AMF updates

2019-03-07 Thread Greg Dove
Correction: That doesn't mean I *have* thought ...etc On Fri, Mar 8, 2019 at 12:41 PM Greg Dove wrote: > I'm not concerned about download size of AMF code unless support for > lesser-used classes are significant. > > OK, so I think I have that. XML is very PAYG. It only works for writing if > yo

Re: AMF updates

2019-03-07 Thread Greg Dove
I'm not concerned about download size of AMF code unless support for lesser-used classes are significant. OK, so I think I have that. XML is very PAYG. It only works for writing if you use XML already elsewhere in your project (if you did not do that, then you could never write an XML instance in

Release Step 013 Succeeded

2019-03-07 Thread Apache Royale CI Server
1. Run ant -f releasesteps.xml Release_Step_013 -Drelease.version=0.9.6 This will download the artifacts then unzip and compile the source artifact. 2. Validate that the compiled artifacts match the downloaded artifacts. 3. If they do, then run ant -f releasesteps.xml Release_Step_013_Sign -Drelea

Re: AMF updates

2019-03-07 Thread Alex Harui
Royale has a JSONReviver that is a first cut at generating ValueObjects from JSON. What we don't know is what the relative performance/bandwidth trade-offs are on AMF vs JSON. However, it really shouldn't matter. Royale can offer both. I'm just wanting the implementation of AMF support in XM

Re: AMF updates

2019-03-07 Thread Greg Dove
Sure Carlos, that's just my view. There are definitely more approaches to 'typing' json than there used to be (I did not use protobuffer yet but it seems interesting). I think the case for AMF becomes stronger for 'new' projects if there is an easy way to move to other things without major changes.

Re: Jewel StyledUIBase positioner

2019-03-07 Thread Carlos Rovira
I'm going to try that now, but I think an HTML element does not has royale_wrapper right? So if I have for example a "div", "aside" or "label" as positioner how can I assign royale_wrapper? El jue., 7 mar. 2019 a las 1:08, Harbs () escribió: > The positioner needs the royale_wrapper set. > > > On

Re: Jewel StyledUIBase positioner

2019-03-07 Thread Carlos Rovira
Hi Alex, I think the purpose is to have a positioner different to element so createElement creates element as normal, but positioner is not element. Or maybe I missing something. To what do you think it should be assigned? El jue., 7 mar. 2019 a las 4:59, Alex Harui () escribió: > I don't think

Re: AMF updates

2019-03-07 Thread Carlos Rovira
Hi Greg El jue., 7 mar. 2019 a las 20:41, Greg Dove () escribió: > > I think AMF in general should be considered legacy support. I would be > surprised, for example, if lots of people start using AMF remoting in new > projects simply because Royale supports it in javascript. I suspect they > are

Re: AMF updates

2019-03-07 Thread Greg Dove
Thanks for various feedback, all. Based on feedback, I will merge this in at the end of my day. @Alex, replying to your points: "Maybe XML doesn't have to work in AMF and some subclass like XMLAMF could. That would be more PAYG, and you might then make XMLAMF an IExternalizable instead of adding

Release Step 013 Succeeded

2019-03-07 Thread Apache Royale CI Server
1. Run ant -f releasesteps.xml Release_Step_013 -Drelease.version=0.9.6 This will download the artifacts then unzip and compile the source artifact. 2. Validate that the compiled artifacts match the downloaded artifacts. 3. If they do, then run ant -f releasesteps.xml Release_Step_013_Sign -Drelea

Release Step 013 Succeeded

2019-03-07 Thread Apache Royale CI Server
1. Run ant -f releasesteps.xml Release_Step_013 -Drelease.version=0.9.6 This will download the artifacts then unzip and compile the source artifact. 2. Validate that the compiled artifacts match the downloaded artifacts. 3. If they do, then run ant -f releasesteps.xml Release_Step_013_Sign -Drelea

Royale_Release_Step_013 - Build # 5 - Still Failing!

2019-03-07 Thread Apache Royale CI Server
Royale_Release_Step_013 - Build # 5 - Still Failing: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_013/5/ to view the results.

Royale_Release_Step_013 - Build # 6 - Still Failing!

2019-03-07 Thread Apache Royale CI Server
Royale_Release_Step_013 - Build # 6 - Still Failing: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_013/6/ to view the results.

Royale_Release_Step_013 - Build # 4 - Still Failing!

2019-03-07 Thread Apache Royale CI Server
Royale_Release_Step_013 - Build # 4 - Still Failing: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_013/4/ to view the results.

Royale_Release_Step_013 - Build # 3 - Still Failing!

2019-03-07 Thread Apache Royale CI Server
Royale_Release_Step_013 - Build # 3 - Still Failing: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_013/3/ to view the results.

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Piotr Zarzycki
Exactly. Cool thanks for solving it. I will test that tomorrow. czw., 7 mar 2019 o 16:27 Carlos Rovira napisał(a): > Hi Piotr, > > just solved it. The problem was caused by a addEventListener that needs to > be removeEventListener, but due to quick copy/paste I left as original... > > In the oth

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Carlos Rovira
Hi Piotr, just solved it. The problem was caused by a addEventListener that needs to be removeEventListener, but due to quick copy/paste I left as original... In the other hand I limite that code only to Android El jue., 7 mar. 2019 a las 15:52, Carlos Rovira () escribió: > ok Piotr, > thanks

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Carlos Rovira
ok Piotr, thanks, will try to solve this regression now sorry for the inconvenience El jue., 7 mar. 2019 a las 15:49, Piotr Zarzycki () escribió: > Hi Carlos, > > Nope. I can work on that tomorrow, so if you can do this earlier please > make it so. > > Thanks, > Piotr > > czw., 7 mar 2019 o 15:41

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Piotr Zarzycki
Hi Carlos, Nope. I can work on that tomorrow, so if you can do this earlier please make it so. Thanks, Piotr czw., 7 mar 2019 o 15:41 Carlos Rovira napisał(a): > Hi Piotr, > > have you tried your solution? I think is a mix of both: > > a) we don't need this update if device is not Android, so

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Carlos Rovira
Hi Piotr, have you tried your solution? I think is a mix of both: a) we don't need this update if device is not Android, so we need to put a solution for maxlength *nly* for that device b) we need to solve the issue you discover, I tried and find the same. So my question is, did you try your so

Re: AMF updates

2019-03-07 Thread Harbs
I think the changes are OK. > On Mar 7, 2019, at 3:41 AM, Greg Dove wrote: > > I meant to do this a few days back, but I continued to make some changes > and improvements, so here goes: > The amf_updates branches of compiler and asjs have the following changes > related to AMFBinaryData: > > -T

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Piotr Zarzycki
I need to think about that, but I just discovered that you are actually checking in whether maxLength is greater than zero, but you are registering event instead removing i. [1] Maybe it should be remove in this place ? [1] https://github.com/apache/royale-asjs/blob/2e91b52be7884ff7da91411ec5119e

Re: AMF updates

2019-03-07 Thread Carlos Rovira
Hi Greg, IMO, and waiting for Harbs comments: I think the code is stable to be merged (again, hope Harbs could test and find what changes he should need, but hopefully should be something doable in his codebase, or maybe he found some small tweaks to be done in the branch). About things still to

Re: Jewel TextInput with StringValidator issue

2019-03-07 Thread Carlos Rovira
Hi Piotr, since that modification was set only to solve maxlength on Android (that doesn't work as in the rest of browsers), I was thinking yesterday on set up the keyup listener in that code only if OSUtils reports Android as the OS. What do you think? El jue., 7 mar. 2019 a las 8:04, Piotr Zarz

Royale_Release_Step_013 - Build # 2 - Still Failing!

2019-03-07 Thread Apache Royale CI Server
Royale_Release_Step_013 - Build # 2 - Still Failing: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_013/2/ to view the results.

Re: AMF updates

2019-03-07 Thread Alex Harui
I read this quickly so may have missed something, but two thoughts came to mind: 1) Maybe XML doesn't have to work in AMF and some subclass like XMLAMF could. That would be more PAYG, and you might then make XMLAMF an IExternalizable instead of adding XML support to the AMF code. 2) Check out

Royale_Release_Step_013 - Build # 1 - Failure!

2019-03-07 Thread Apache Royale CI Server
Royale_Release_Step_013 - Build # 1 - Failure: Check console output at http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_013/1/ to view the results.

AMF updates

2019-03-07 Thread Greg Dove
I meant to do this a few days back, but I continued to make some changes and improvements, so here goes: The amf_updates branches of compiler and asjs have the following changes related to AMFBinaryData: -The BinaryData base class had a minor shift with the writeBytes/readBytes methods. The origin