Release Step 001a Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_001a_If_Utils and run the following commands: git push You will need your Apache/Github username and 2FA token.

Release Step 002 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_002 and run the following commands: git push git push origin org.apache.royale.compiler-0.9.6-rc1 You will need your Apache/Github username and 2FA token.

Release Step 002a Succeeded

2019-09-16 Thread Apache Royale CI Server
Continue on to Release Step 003

Release Step 003 Succeeded

2019-09-16 Thread Apache Royale CI Server
>From the royale-compiler repo: 1. If you are releasing the utils jars (compiler-jburg-types and compiler-build-tools) - you have set in previous step for mentioned projects version ex. 1.1.0 not snapshot, Run: ant -f releasesteps.xml Release_Step_003 -Dutils=true -Drelease.version=0.9.6 Otherw

Release Step 004 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_004 and run the following commands: git push git checkout release/0.9.6 git push -u origin release/0.9.6 You will need your Apache/Github username and 2FA token.

Release Step 005 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_005 and run the following commands: git push You will need your Apache/Github username and 2FA token.

Release Step 005a Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_005a_If_Utils and run the following commands: git push You will need your Apache/Github username and 2FA token.

Release Step 006 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_006 and run the following commands: git push git push origin org.apache.royale.typedefs-0.9.6-rc1 You will need your Apache/Github username and 2FA token.

Release Step 007 Succeeded

2019-09-16 Thread Apache Royale CI Server
>From the royale-typedefs repo: 1. Run ant -f releasesteps.xml Release_Step_007 -Drelease.version=0.9.6 -DskipTests=true This will download the artifacts then unzip and compile the source artifact. 2. Validate that the compiled artifacts match the downloaded artifacts. 3. If they do, then run ant

Release Step 008 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_008 and run the following commands: git push git checkout release/0.9.6 git push -u origin release/0.9.6 You will need your Apache/Github username and 2FA token.

Release Step 008 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_008 and run the following commands: git push git checkout release/0.9.6 git push -u origin release/0.9.6 You will need your Apache/Github username and 2FA token.

Release Step 009 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_009 and run the following commands: git push You will need your Apache/Github username and 2FA token.

Release Step 010 Succeeded

2019-09-16 Thread Apache Royale CI Server
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_010 and run the following commands: git push git push origin org.apache.royale.framework-0.9.6-rc1 You will need your Apache/Github username and 2FA token.

Release Step 011 Succeeded

2019-09-16 Thread Apache Royale CI Server
>From the royale-asjs repo: 1. Run ant -f releasesteps.xml Release_Step_011 -Drelease.version=0.9.6 -DskipTests=true This will download the artifacts then unzip and compile the source artifact. 2. Validate that the compiled artifacts match the downloaded artifacts. 3. If they do, then run ant -f r

Re: [royale-asjs] branch release/0.9.6 updated: Update RELEASE_NOTES.md

2019-09-16 Thread Piotr Zarzycki
Hi Andrew, I'm sorry but I already started preparing artifacts, so this probably won't go to 0.9.6. Thanks, Piotr pon., 16 wrz 2019 o 11:55 napisał(a): > This is an automated email from the ASF dual-hosted git repository. > > andreww pushed a commit to branch release/0.9.6 > in repository http

Re: [royale-asjs] branch release/0.9.6 updated: Update RELEASE_NOTES.md

2019-09-16 Thread Andrew Wetmore
The hurricane and is aftermath slowed me down. Anyhow all my edits were minor. On Mon, Sep 16, 2019, 7:01 AM Piotr Zarzycki, wrote: > Hi Andrew, > > I'm sorry but I already started preparing artifacts, so this probably won't > go to 0.9.6. > > Thanks, > Piotr > > pon., 16 wrz 2019 o 11:55 napis

Re: [royale-asjs] branch release/0.9.6 updated: Update RELEASE_NOTES.md

2019-09-16 Thread Piotr Zarzycki
I know Andrew. No problem ! :) pon., 16 wrz 2019 o 12:39 Andrew Wetmore napisał(a): > The hurricane and is aftermath slowed me down. Anyhow all my edits were > minor. > > On Mon, Sep 16, 2019, 7:01 AM Piotr Zarzycki, > wrote: > > > Hi Andrew, > > > > I'm sorry but I already started preparing ar

Jenkins build is back to normal : royale-typedefs #1621

2019-09-16 Thread Apache Royale CI Server
See

Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Josh Tynjala
I was looking through the Closure compiler annotations, and I noticed @nocollapse: Denotes a property that should not be collapsed by the compiler into a > variable. The primary use for @nocollapse is to allow exporting of mutable > properties. > https://github.com/google/closure-compiler/wiki/An

Jenkins build is back to normal : royale-asjs_jsonly #3549

2019-09-16 Thread Apache Royale CI Server
See

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Alex Harui
IMO, the -warn-public-vars is more about the "renaming" mentioned in that link than the "collapse". If you have: Package { Class Josh { Public var name:String; } Var foo:Josh = new Josh(); foo.name = 'josh'; I don't think @nocollapse will prevent renaming the 'name' property to something ran

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Josh Tynjala
I guess I was assuming that @nocollapse combined with @export would make it also prevent renaming. I suppose I can test it and see what happens. -- Josh Tynjala Bowler Hat LLC On Mon, Sep 16, 2019 at 9:54 AM Alex Harui wrote: > IMO, the -warn-public-vars is more about t

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Alex Harui
Feel free to revisit. IIRC, the issue is that you can't @export a "var". You can only @export a function because @export sets up a reference to the renamed function and you can't set up a reference to simple vars. Class Josh { Static var foo:int = 1; } Compiles to: Josh.foo = 1; Gets re

Re: [royale-asjs] branch release/0.9.6 updated: Update RELEASE_NOTES.md

2019-09-16 Thread OmPrakash Muppirala
This can always go in the next release :-) Thanks, Om On Mon, Sep 16, 2019 at 4:32 AM Piotr Zarzycki wrote: > I know Andrew. No problem ! :) > > pon., 16 wrz 2019 o 12:39 Andrew Wetmore napisał(a): > > > The hurricane and is aftermath slowed me down. Anyhow all my edits were > > minor. > > > >

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Josh Tynjala
You're right. After a number of tests, I cannot find any annotation (or combination of them) that will prevent the renaming of variables defined on a prototype. All of the official advice that I see from Google suggests quoting the properties (or using externs). So, from a Royale perspective, it lo

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Alex Harui
I'm not sure I understand your proposal. Are you proposing that all public variables will be quoted and thus not renamed so we never warn again? I am not in favor of that. IMO, the vast majority of public vars can be renamed without penalty. It is only certain classes that will be mapped to

Build failed in Jenkins: royale-asjs_MXTests #1159

2019-09-16 Thread Apache Royale CI Server
See -- [...truncated 1001.78 KB...] [mxmlc] scanning for overrides: ObjectUtil [mxmlc] scanning for overrides: SolidBorderUtil [mxmlc] scanning

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Josh Tynjala
Unfortunately, people actively avoid using public vars because we warn about them. Our warnings are too aggressive if it doesn't actually matter most of the time. Plus, this warning leaves a bad impression because it's such a basic feature of the language that pretty much everyone uses. What can w

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Josh Tynjala
I was thinking about this some more, and is there anything else that's public that also we allow to be renamed? I'm not aware of anything, but maybe I've missed something. If it's true, it seems inconsistent to allow public variables to be the one exception that should be renamed. If public methods

Jenkins build is back to normal : royale-asjs_jsonly #3551

2019-09-16 Thread Apache Royale CI Server
See

Build failed in Jenkins: royale-asjs_MXTests #1160

2019-09-16 Thread Apache Royale CI Server
See -- [...truncated 1000.82 KB...] [mxmlc] scanning for overrides: ObjectUtil [mxmlc] scanning for overrides: SolidBorderUtil [mxmlc] scanning

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

2019-09-16 Thread Alex Harui
Some folks want us to get smarter and not automatically export all public methods and getter/setters. There are a lot of just-in-case strings in Royale apps. That's not good. So better control over things even after compiling without being painful to use is the goal. My 2 cents, -Alex On 9