Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Greg Dove
Hi Chris, I haven't followed the discussion until now, that seems pretty clear to me. The compiler part merge sounds fine to me the way you describe it - it sounds like it is something that is inevitable at some point, but 'harmless' at any point, right? I'm sorry I have been a bit 'absent' because

AW: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Christofer Dutz
Ok ... here goes: I thought I had been clear with what I wanted to do, but it seems I haven't been clear enough: To build the new distribution, you need to checkout my feature branch in the asjs repo (feature/distribution-allignment) However, for this to work, you need a tiny change I have in t

AW: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Christofer Dutz
Hi Piotr, Well, I'm not referring to my changes on asjs ... I'm referring to the changes on the compiler. All this does is create a new artifact. If you managed to build the compiler in my branch, then all that should have worked, worked. Chris -Ursprüngliche Nachricht- Von: Piotr Zar

Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Harbs
No. If there are issues they should be resolved. I don’t understand Maven well enough to have a technical opinion. I was just saying that it seems useful for a release, so I’m interested in this getting it resolved quickly. Thanks, Harbs > On Mar 7, 2021, at 5:27 PM, Piotr Zarzycki wrote: >

Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Piotr Zarzycki
Harbs, Are you proposing merge this even with issue which I have ? Thanks, Piotr On Sun, 7 Mar 2021 at 16:24, Harbs wrote: > I’m interested in doing a release ASAP. This seems really useful for > releasing. > > I’m also not sure if it makes sense to first integrate Josh’s work on > playergloba

Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Piotr Zarzycki
*I don’t see the reason. On Sun, 7 Mar 2021 at 16:25, Piotr Zarzycki wrote: > When it will work for me I will be +1 for merge. When I tested on Friday > it didn’t work, so I do see reason why it should be on dev. > > On Sun, 7 Mar 2021 at 16:07, Christofer Dutz > wrote: > >> It's not a hurry, >

Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Piotr Zarzycki
When it will work for me I will be +1 for merge. When I tested on Friday it didn’t work, so I do see reason why it should be on dev. On Sun, 7 Mar 2021 at 16:07, Christofer Dutz wrote: > It's not a hurry, > > But it's a side-effect free merge and if there are others wanting to join > in (Especia

Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Harbs
I’m interested in doing a release ASAP. This seems really useful for releasing. I’m also not sure if it makes sense to first integrate Josh’s work on playerglobal. Josh, are you finished that or is there more to do? Thanks, Harbs > On Mar 7, 2021, at 3:43 PM, Christofer Dutz wrote: > > Hi al

AW: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Christofer Dutz
It's not a hurry, But it's a side-effect free merge and if there are others wanting to join in (Especially Ant folks will probably be interested) I thought this would simplify things for these non-Maven-natives. Chris -Ursprüngliche Nachricht- Von: Piotr Zarzycki Gesendet: Sonntag, 7.

Re: Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Piotr Zarzycki
Chris, I personally don’t have any problems with testing when it’s on branch. Not sure what’s the hurry with that? I should have time to make another test after your commit on Monday/Tuesday. Thanks, Piotr On Sun, 7 Mar 2021 at 14:43, Christofer Dutz wrote: > Hi all, > > it would simplify tes

Merge the compiler-pr for distribution alignment?

2021-03-07 Thread Christofer Dutz
Hi all, it would simplify testing the distribution stuff a lot, if this PR would be merged: Feature/distribution allignment by chrisdutz * Pull Request #180 * apache/royale-compiler (github.com) It simply packs all scripts in the compiler bin

AW: PRs ready for distribution alignment

2021-03-07 Thread Christofer Dutz
Hi Piotr, if you don't enable the "option-with-swf" it's the JS-only version. The reason for setting things up that way 5 years ago, was that we then knew that SWF was going to be fading out and JS to be the new standard. So, we chose the default to work without having to accept Adobe License Ag

Re: PRs ready for distribution alignment

2021-03-07 Thread Piotr Zarzycki
Chris, I have used on Friday version which has been build with following command: mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution Which one is that ? If this command build swf version - I think default should be ja only. Thanks, Piotr On Sun, 7 Mar 2021 at 13:03,

AW: PRs ready for distribution alignment

2021-03-07 Thread Christofer Dutz
Hi all, I just pushed some changes handing the "without-swf" version. I now create the dummy files the FlashBuilder seems to require. Also does the build now clean out the "library-path" for the without-swf version. So, it should now be more aligned with the Ant build. @Piotr ... Are you still

Re: PRs ready for distribution alignment

2021-03-07 Thread Piotr Zarzycki
Yep it doesn’t, but I can build my project with that sdk and cannot with maven distribution, so some configs has changed. On Sun, 7 Mar 2021 at 11:56, Christofer Dutz wrote: > Hi Piotr, > > So, I just downloaded the js-only version and that seems to be quite empty > too. > > It does seem to cont

AW: PRs ready for distribution alignment

2021-03-07 Thread Christofer Dutz
Hi Piotr, So, I just downloaded the js-only version and that seems to be quite empty too. It does seem to contain airglobal and playerglobal, JewelTheme and a quite big lib called KeepsFBFromHanging.swc ... but in general this directory doesn't contain any of the Project swcs. Chris -Urs

Re: mx:ComboBox using prompt and labelFunction questions

2021-03-07 Thread Yishay Weiss
Hi, Before we start a thread on how to add prompt to mx:ComboBox can you just confirm that you've seen the walkthrough [1] ? [1] Getting MX Alert To Run · apache/royale-asjs Wiki (github.com) Thanks __