Duplicated TextNode in HTML module

2017-12-16 Thread Piotr Zarzycki
Hi Harbs, I'm investigating some issue in Moonshine with Royale and I have noticed that after your changes in HTML module component TextNode and InnerHTML is in "html-manifest.xml" and in "basic-manifest.xml" of that module. Is it for purpose or simply mistake ? Thanks, -- Piotr Zarzycki Patr

Re: Duplicated TextNode in HTML module

2017-12-16 Thread Harbs
It was on purpose. That lets you use TextNode and InnerHTML using both the basic and the html namespaces. Those are likely to be used with Basic components in addition to HTML ones. > On Dec 16, 2017, at 6:58 PM, Piotr Zarzycki wrote: > > Hi Harbs, > > I'm investigating some issue in Moonshin

Re: Duplicated TextNode in HTML module

2017-12-16 Thread Piotr Zarzycki
Ok Thanks. Another question - Do you see in VSCode duplicate definition in code completion for example Accordion ? Thanks, Piotr 2017-12-16 18:26 GMT+01:00 Harbs : > It was on purpose. That lets you use TextNode and InnerHTML using both the > basic and the html namespaces. Those are likely to

Re: Duplicated TextNode in HTML module

2017-12-16 Thread Harbs
Yes. I see duplication. In some places many times. For example, ContainerBase shows up 9 times. > On Dec 16, 2017, at 7:37 PM, Piotr Zarzycki wrote: > > Ok Thanks. > > Another question - Do you see in VSCode duplicate definition in code > completion for example Accordion ? > > Thanks, Piotr >

Re: Duplicated TextNode in HTML module

2017-12-16 Thread Piotr Zarzycki
I see the same in Moonshine. Do you think that is problem in extension or somewhere in our code ? I was digging into the modules but didn't found anything. I have checked also for Jsonly package what actually is in swcs, but also no clue what is happen. Piotr 2017-12-16 18:42 GMT+01:00 Harbs :

Re: Duplicated TextNode in HTML module

2017-12-16 Thread Harbs
No idea. I was planning on asking Josh at some point. > On Dec 16, 2017, at 7:47 PM, Piotr Zarzycki wrote: > > I see the same in Moonshine. Do you think that is problem in extension or > somewhere in our code ? I was digging into the modules but didn't found > anything. I have checked also for J

Re: Duplicated TextNode in HTML module

2017-12-16 Thread Piotr Zarzycki
Anyone who use Flash Builder seeing also duplication ? Thanks, Piotr 2017-12-16 18:47 GMT+01:00 Piotr Zarzycki : > I see the same in Moonshine. Do you think that is problem in extension or > somewhere in our code ? I was digging into the modules but didn't found > anything. I have checked also f

Re: Duplicated TextNode in HTML module

2017-12-17 Thread Alex Harui
In FB, ContainerBase only shows up once in AS code completion and not in MXML (since it isn't in a manifest). HTH, -Alex On 12/16/17, 9:56 AM, "Piotr Zarzycki" wrote: >Anyone who use Flash Builder seeing also duplication ? > >Thanks, Piotr > >2017-12-16 18:47 GMT+01:00 Piotr Zarzycki : > >> I s

Re: Duplicated TextNode in HTML module

2017-12-18 Thread Piotr Zarzycki
Hi Alex, Thanks for the information. I'm still not sure where the bug is. It is for sure not in the Moonshine code - I have checked it and Harbs confirmed that he is seeing the same in VSCode. I don't have such problems with Flex SDK. Thanks, Piotr 2017-12-18 6:39 GMT+01:00 Alex Harui : > In

Re: Duplicated TextNode in HTML module

2017-12-18 Thread Piotr Zarzycki
Hi Guys, It look like those duplication that is something on the Royale. Josh took a look into the problem [1]. Should we change compile-js-config.xml or it is something which we need to look deeper somewhere ? [1] https://github.com/prominic/Moonshine-IDE/issues/87#issuecomment-352525906 Thank

Re: Duplicated TextNode in HTML module

2017-12-18 Thread Harbs
I think the problem is a bit deeper. Using external-library-path is not going to work for js compiles because it needs to link the includes when compiling to JS. catalog.xml needs to be generates sans the dependency classes though (I think). I’m not sure the right way to go about that. For most

Re: Duplicated TextNode in HTML module

2017-12-18 Thread Alex Harui
I think Josh correctly analyzed that the JS SWCs have duplicate entries. As Harbs says, the compiler doesn't have an easy way to distinguish between external definitions that don't need goog.require and ones that do, so we currently have duplicate entries by putting upstream SWCs on the library-pa

Re: Duplicated TextNode in HTML module

2017-12-18 Thread Piotr Zarzycki
Alex, Flash Builder has such tolerance ? Do you have any knowledge how that IDE handles such thing ? I will spend some time to setup Intellij and see how am I seeing this thing there. I completely agree with you that we have big fish to fry - This is exactly one of them. It affects two IDEs which

Re: Duplicated TextNode in HTML module

2017-12-18 Thread Alex Harui
Flash Builder does not seem to be showing duplicates. At minimum, it can just sort all of the classes it finds and toss out duplicates. The way the compiler deals with duplicates is by using the compile time stamp in the catalog.xml and always let source-path entries win over library-path entries