Re: Heads up on XML

2019-11-28 Thread Harbs
I had removed that line to avoid writing “element”. I just changed it to delete the property to get rid of the “TEXT” on instantiation. > On Nov 28, 2019, at 8:29 PM, Greg Dove wrote: > > ' I don’t see that in the Ecma spec.' > > yeah, it was fun working on this. (irony) . When things were not

Re: Heads up on XML

2019-11-28 Thread Greg Dove
' I don’t see that in the Ecma spec.' yeah, it was fun working on this. (irony) . When things were not clear, I always used swf behavior as the 'spec'. On Fri, Nov 29, 2019 at 7:25 AM Harbs wrote: > Yeah. I see it’s supposed to wrap the elements. Weird. I don’t see that in > the Ecma spec. >

Re: Heads up on XML

2019-11-28 Thread Harbs
Yeah. I see it’s supposed to wrap the elements. Weird. I don’t see that in the Ecma spec. I see what I messed up. I’ll revert that bit. > On Nov 28, 2019, at 8:20 PM, Greg Dove wrote: > > You mean this (hopefully the xml angle brackets won't be mangled in your > view of this)? > > var xml:XML

Re: Heads up on XML

2019-11-28 Thread Greg Dove
You mean this (hopefully the xml angle brackets won't be mangled in your view of this)? var xml:XML = ; xml.appendChild("test1"); xml.appendChild("test2"); xml.appendChild(); xml.appendChild("test3"); xml.appendChild("test4"); trace(xml.toXMLString()) output in swf: test1 test2 test3

Re: Heads up on XML

2019-11-28 Thread Harbs
I can’t imagine where test3 comes from when you append “test3”... It should be a text node. No? > On Nov 28, 2019, at 8:09 PM, Greg Dove wrote: > > OK, I will check it now. > > On Fri, Nov 29, 2019 at 7:08 AM Harbs wrote: > >> I’m getting two test failures on the XML tests. >> >> testXMLNo

Re: Heads up on XML

2019-11-28 Thread Greg Dove
OK, I will check it now. On Fri, Nov 29, 2019 at 7:08 AM Harbs wrote: > I’m getting two test failures on the XML tests. > > testXMLNormalize is failing, but the test looks wrong to me. Could you > take a look? > > > On Nov 28, 2019, at 7:32 PM, Greg Dove wrote: > > > > Oh - just saw this. Thank

Re: Heads up on XML

2019-11-28 Thread Harbs
I’m getting two test failures on the XML tests. testXMLNormalize is failing, but the test looks wrong to me. Could you take a look? > On Nov 28, 2019, at 7:32 PM, Greg Dove wrote: > > Oh - just saw this. Thanks. > Please ignore my comments in the other thread :). > > > On Fri, Nov 29, 2019 a

Re: Heads up on XML

2019-11-28 Thread Greg Dove
Harbs, I don't have time to look into it right now, but those last changes break a couple of royaleunit tests. The tests could be wrong (but for the most part they do run the same tests between swf and js). If you ever want to test these in isolation after you make changes, you can go into the XM

Re: Heads up on XML

2019-11-28 Thread Greg Dove
Oh - just saw this. Thanks. Please ignore my comments in the other thread :). On Fri, Nov 29, 2019 at 6:12 AM Harbs wrote: > I finally got the nerve together to update my local environment. > > The changes look pretty good. > > I made a couple of small changes. > > One fixes hasAttribute which

Re: Heads up on XML

2019-11-28 Thread Harbs
I finally got the nerve together to update my local environment. The changes look pretty good. I made a couple of small changes. One fixes hasAttribute which somehow broke with your changes. The second is a small tweak to the memory optimizations. The memory footprint seems to be a bit smaller

Re: Heads up on XML

2019-10-08 Thread Greg Dove
Hi Piotr, quick response below... > > generate-swcs-for-swf > > > org.apache.royale.framework > Core > 0.9.7-SNAPSHOT > swc > swf > > > > > How this activat

Re: Heads up on XML

2019-10-08 Thread Piotr Zarzycki
Hi Greg, Questions inline. pon., 7 paź 2019 o 01:49 Greg Dove napisał(a): > Hi Piotr, just a quick follow-up to let you know that was all good, I had > already tested the merge and conflict resolution myself and was ready to > step in and help with that if that was necessary, but you already di

Re: Heads up on XML

2019-10-06 Thread Greg Dove
Ok, thanks Alex, I will do that tomorrow. On Mon, Oct 7, 2019 at 4:02 PM Alex Harui wrote: > Improvements to the Maven builds and Ant builds are always welcome. Just > make sure they work from a truly clean machine (empty the local Maven repo, > build without access to the snapshots repo, etc)

Re: Heads up on XML

2019-10-06 Thread Alex Harui
Improvements to the Maven builds and Ant builds are always welcome. Just make sure they work from a truly clean machine (empty the local Maven repo, build without access to the snapshots repo, etc). There are some issues with profile inheritance in Maven, but I don't understand your proposal e

Re: Heads up on XML

2019-10-06 Thread Greg Dove
Hi Piotr, just a quick follow-up to let you know that was all good, I had already tested the merge and conflict resolution myself and was ready to step in and help with that if that was necessary, but you already did it before I got a chance to send my email about that. :) I have to say: well done

Re: Heads up on XML

2019-10-06 Thread Greg Dove
Hi Piotr, I will check that in the morning local time... in about 8 hours. On Sun, 6 Oct 2019, 21:54 Piotr Zarzycki, wrote: > Hi Greg, > > I run into merge conflict during merge release branch to develop into file > which you have changed lately. Could you please verify on develop if I > didn't

Re: Heads up on XML

2019-10-06 Thread Piotr Zarzycki
Hi Greg, I run into merge conflict during merge release branch to develop into file which you have changed lately. Could you please verify on develop if I didn't remove anything, if I resolve conflict correctly. [1] [1] https://github.com/apache/royale-compiler/blob/develop/compiler-jx/src/main/j

Re: Heads up on XML

2019-10-02 Thread Harbs
OK. I’ll test memory with and without your changes and let you know the differences. :-) Harbs > On Oct 2, 2019, at 11:29 AM, Greg Dove wrote: > > @harbs > > FYI in addition to some other stuff, I am close to pushing my updates to > XML. This should be in the next hour or so. > > I kept the

Re: Heads up on XML

2019-10-02 Thread Greg Dove
@harbs FYI in addition to some other stuff, I am close to pushing my updates to XML. This should be in the next hour or so. I kept the QName caching pretty close to how you had it, with only some minor changes. I tried to do some extra memory optimization, and in theory it should provide better r

Re: Heads up on XML

2019-09-09 Thread Alex Harui
No worries. I spent today on release stuff as well. On 9/9/19, 11:01 PM, "Greg Dove" wrote: And... I'm still going. I keep finding things that need addressing. I am in attributes now. Anyway, I haven't gotten to the memory testing yet and I need to focus tomorrow on showin

Re: Heads up on XML

2019-09-09 Thread Greg Dove
And... I'm still going. I keep finding things that need addressing. I am in attributes now. Anyway, I haven't gotten to the memory testing yet and I need to focus tomorrow on showing my client progress, so I'm sorry but this code will be another couple of days. If you do look into the as2 XMLDocu

Re: Heads up on XML

2019-09-08 Thread Alex Harui
No problem. I've spent today trying to fix the build in the Ant source package. -Alex On 9/8/19, 10:03 PM, "Greg Dove" wrote: Not quite there yet with the final changes, I'm afraid. I'm getting close... should be tomorrow my time. On Sun, Sep 8, 2019 at 7:32 AM Greg D

Re: Heads up on XML

2019-09-08 Thread Greg Dove
Not quite there yet with the final changes, I'm afraid. I'm getting close... should be tomorrow my time. On Sun, Sep 8, 2019 at 7:32 AM Greg Dove wrote: > > Yeah thanks Josh, Alex made a suggestion for that option too, it was the > one I thought I would try first. I hope to get there later toda

Re: Heads up on XML

2019-09-07 Thread Greg Dove
Yeah thanks Josh, Alex made a suggestion for that option too, it was the one I thought I would try first. I hope to get there later today, so I will see if I can figure that out. On Sun, Sep 8, 2019 at 7:20 AM Josh Tynjala wrote: > I think the DITA files generated by asdoc are pretty big too, s

Re: Heads up on XML

2019-09-07 Thread Josh Tynjala
I think the DITA files generated by asdoc are pretty big too, so they're probably really useful for your testing. - Josh On Friday, September 6, 2019, Greg Dove wrote: > 'I think that SWFDump will generate valid XML and there is a way to get > DITA files from Flex ASDoc that are valid XML.' > So

Re: Heads up on XML

2019-09-06 Thread Greg Dove
'I think that SWFDump will generate valid XML and there is a way to get DITA files from Flex ASDoc that are valid XML.' Sounds like a good idea for some large xml files. I did not use that yet, so will take a look and see if I can figure it out. Thanks! On Sat, Sep 7, 2019 at 12:30 PM Greg Dove

Re: Heads up on XML

2019-09-06 Thread Alex Harui
Thanks. Yeah I remember that is commented out. In a quick look, it wasn't clear why XMLDocument was used instead of E4x in the WebService code. I will probably just use e4x and see what happens. -Alex On 9/6/19, 5:30 PM, "Greg Dove" wrote: Just to clarify I was referring to this s

Re: Heads up on XML

2019-09-06 Thread Greg Dove
Just to clarify I was referring to this stuff here: https://github.com/apache/royale-asjs/blob/8ab1d813ee2f72bab957f9485e56ad89dcf6e1ab/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/http/AbstractOperation.as#L1038 with '//old XML style' On Sat, Sep 7, 2019 at 12:24 PM Alex Harui w

Re: Heads up on XML

2019-09-06 Thread Alex Harui
I haven't looked at what XML is used/supported by MX HTTPService. It looks like WebService does use MX HTTPService. I am currently migrating other things that WebService needs (XMLEncoder/Decoder, SOAPEncoder/Decoder). These are new files that aren't in the repo yet, so HTTPService couldn't b

Re: Heads up on XML

2019-09-06 Thread Greg Dove
Actually I know you are looking into the WSDL stuff maybe this is going to be important for that (not sure)? My goal is to get the XML stuff tidied up and ready to push by end of day tomorrow, worst case the following morning, local time (UTC+12). I also need to find some big XML test cases to

Re: Heads up on XML

2019-09-06 Thread Greg Dove
Thanks for checking that. child is specified in 13.4.4.6 and essentially calls [[Get]] (After cycling through this kind of thing a few times, I found the easiest way to find methods is to search in the spec for 'e.mehodName' which gets you XML.prototype.methodName) and [[Get]] is specified in 9.1

Re: Heads up on XML

2019-09-06 Thread Alex Harui
FWIW, I went and looked at the ABC. The first syntax sets up a getProperty just like any other property fetch. The second (as expected) calls "child()". I've looked at the E4X spec a couple of times now and cannot see where the behavior we are seeing in child() is specified so I am going to a

Re: Heads up on XML

2019-09-05 Thread Greg Dove
Oh that is a good find! And perfect timing :) Thanks Alex, I am pretty sure that answers the question! (It quite specifically describes what I was seeing, I don't think it makes a difference whether it is attributes or elements) And yes, I agree it should be the implemented to give the same result

Re: Heads up on XML

2019-09-05 Thread Alex Harui
Out of pure random chance, I was starting the migration of WebService which had a dependency on XMLUtil which contained the comment: //xml.attribute(QName) will also return local no-namespace attributes //even if we are looking for a specific full qualified name. So, still could

Re: Heads up on XML

2019-09-04 Thread Alex Harui
I read the example incorrectly. So yeah, it should return 0 and empty string in both cases, IMO. There might be some subtlety in how the namespaces are specified for a QName or how QName works in child(). HTH, -Alex On 9/4/19, 11:33 AM, "Greg Dove" wrote: Good idea. I'll check the swf

Re: Heads up on XML

2019-09-04 Thread Greg Dove
Yeah, I saw that ;) Don't worry, I am aware of it. My first goal is to make sure it works like it should, because that comes first, and then to optimize. I'll check the memory side of things and make sure it's at least the same as before. If you can point me to some publicly accessible large test

Re: Heads up on XML

2019-09-04 Thread Harbs
Heads up: I did some (on first blush) odd things in XML related to QNames. QNames are pooled and many XML properties are not initialized by default. The reason I did this was it avoided many MB of memory waste for complex XML. Please don’t mess that up. Thanks, Harbs > On Sep 4, 2019, at 1:02

Re: Heads up on XML

2019-09-04 Thread Greg Dove
Good idea. I'll check the swf output, although probably tomorrow as I need to focus on something else today. ' I would have expected both to return "1" and the node. ' In that example I would expect the opposite (because the the link node being returned by the second query is not in the specified

Re: Heads up on XML

2019-09-04 Thread Alex Harui
Speaking of multinames, what is the ABC code generated by the Flex compiler for the two cases? It might contain some clues. I would have expected both to return "1" and the node. But I did see in the spec the notion of "InScopeNamespaces". I generally hate reading specs like these so I am no

Re: Heads up on XML

2019-09-04 Thread Greg Dove
'Have you rummaged through the spec?' Yes, if anything I probably need to step away from it and experience the world a bit more! I have been focused on each portion of the spec as I create unit tests and verify things between the player and the Royale implementation. I've also glanced a few times i

Re: Heads up on XML

2019-09-04 Thread Alex Harui
Don't know. Have you rummaged through the spec? https://www.ecma-international.org/publications/files/ECMA-ST-WITHDRAWN/Ecma-357.pdf HTH, -Alex On 9/4/19, 3:11 AM, "Greg Dove" wrote: This is particularly for Harbs and Yishay, as I think you are both (or both have been) using XML quite

Heads up on XML

2019-09-04 Thread Greg Dove
This is particularly for Harbs and Yishay, as I think you are both (or both have been) using XML quite a bit. I have quite a few fixes coming. All with tests that match on swf and js. I am currently working to demonstrate proof of concept to a prospective client for migration of a Flex app. The a