Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Carlos Rovira
Hi Harbs, I just check it and all seems to work ok :) 2018-06-11 13:30 GMT+02:00 Carlos Rovira : > > > 2018-06-11 13:26 GMT+02:00 Harbs : > >> I changed toString() to be a pointer to readUTFBytes. >> > > ok, I'll check if it works for UID generation as I can > > >> >> Uint16Array will not work f

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Carlos Rovira
2018-06-11 13:26 GMT+02:00 Harbs : > I changed toString() to be a pointer to readUTFBytes. > ok, I'll check if it works for UID generation as I can > > Uint16Array will not work for UTF8. It might work for UTF16. Not sure. It > might be interesting to see if the String.fromCharCode.apply approa

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Harbs
I changed toString() to be a pointer to readUTFBytes. Uint16Array will not work for UTF8. It might work for UTF16. Not sure. It might be interesting to see if the String.fromCharCode.apply approach would work with Uint8Array. If yes, the readUTFBtyes method could possibly be simplified. I’m not

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Carlos Rovira
Hi Harbs, see my fix, and if you think is not ok, feel free to update as you think. Then I can try AMF generation of UID and see if it continues working right ok? I think with my latest commit I revert to how this was working...if I'm not missing something thanks 2018-06-11 13:14 GMT+02:00 H

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Carlos Rovira
Hi, just committed a solution that does the same done in "readUTFBytes" on line 985 Let me know if this solves the issue 2018-06-11 13:07 GMT+02:00 Carlos Rovira : > Hi, > > no problem, we can go back to how it was that line before. I changed it be > have the same in all that class, but wasn't aw

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Harbs
Why do you need toString rather than readUTFBytes()? FWIW, readUTFBytes() already falls back to TextDecoder when available. > On Jun 11, 2018, at 2:07 PM, Carlos Rovira wrote: > > Hi, > > no problem, we can go back to how it was that line before. I changed it be > have the same in all that cla

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Carlos Rovira
Hi, no problem, we can go back to how it was that line before. I changed it be have the same in all that class, but wasn't aware of that problem. So I'll change to what we had, and make to String do the same. I think it should work the same and as well work on IE/Edge I'll take a look right now

Re: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Harbs
FWIW, I always check web API support in MDN and caniuse.com before using them in Royale. Some more details win this specific issue: It looks like you added toString() to BinaryData and changed UIDUtils to use that. I don’t think a toString method in BinaryData makes sense. Flash was very smart

RE: [royale-asjs] branch develop updated: fix latest commit, since binary data to string method was not really working

2018-06-11 Thread Yishay Weiss
Carols, This breaks our app on IE and Edge, as they don’t support TextDecoder. Can you fix this? From: carlosrov...@apache.org Sent: Sunday, May 27, 2018 11:29:14 PM To: comm...@royale.apache.org Subject: [royale-asjs] branch develop updated: fix latest comm