Review Request 33199: Coordinator stream

2015-04-14 Thread Naveen Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33199/ --- Review request for samza. Repository: samza Description --- SAMZA 465

Re: Review Request 33142: [SAMZA-561] Review in progress

2015-04-14 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33142/#review79941 --- I will continue the rest of the review after this patch is rebased a

Re: Updating samza-sql branch to Java 1.7

2015-04-14 Thread Yi Pan
Merged master to samza-sql. On Tue, Apr 14, 2015 at 2:57 PM, Jakob Homan wrote: > Yes, I removed the tests for JDK6 yesterday. We're 1.7 or above now > for development. > > On 14 April 2015 at 12:47, Milinda Pathirage > wrote: > > Hi Devs, > > > > Calcite dropped support for Java 1.6 in 1.1.0-

Re: Updating samza-sql branch to Java 1.7

2015-04-14 Thread Jakob Homan
Yes, I removed the tests for JDK6 yesterday. We're 1.7 or above now for development. On 14 April 2015 at 12:47, Milinda Pathirage wrote: > Hi Devs, > > Calcite dropped support for Java 1.6 in 1.1.0-incubating. I want to use > Calcite 1.2.0-incubating-SNAPSHOT in samza-sql branch. Is it okay to u

Re: Review Request 33146: Adding a new KV store contract: BatchingKeyValueStore

2015-04-14 Thread Naveen Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33146/#review80124 --- samza-kv/src/main/java/org/apache/samza/storage/kv/BatchingKeyValue

Re: Updating samza-sql branch to Java 1.7

2015-04-14 Thread Yi Pan
Hi, Chris, Let me do it. Thanks! -Yi On Tue, Apr 14, 2015 at 2:19 PM, Chris Riccomini wrote: > @Yi, are you going to merge master into the samza-sql branch, or should I? > > On Tue, Apr 14, 2015 at 2:02 PM, Yi Pan wrote: > > > Hi, Milinda, > > > > Jacob already committed a change to remove Ja

Re: Updating samza-sql branch to Java 1.7

2015-04-14 Thread Chris Riccomini
@Yi, are you going to merge master into the samza-sql branch, or should I? On Tue, Apr 14, 2015 at 2:02 PM, Yi Pan wrote: > Hi, Milinda, > > Jacob already committed a change to remove Java 1.6 support in SAMZA-646. I > think that it would be fine to move samza-sql branch to Java 1.7. > > Regards

Re: Review Request 33146: Adding a new KV store contract: BatchingKeyValueStore

2015-04-14 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33146/#review80110 --- samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueS

Re: Review Request 33146: Adding a new KV store contract: BatchingKeyValueStore

2015-04-14 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33146/#review80036 --- I'm concerned that there might be an issue with this approach. In B

Re: Updating samza-sql branch to Java 1.7

2015-04-14 Thread Yi Pan
Hi, Milinda, Jacob already committed a change to remove Java 1.6 support in SAMZA-646. I think that it would be fine to move samza-sql branch to Java 1.7. Regards. -Yi On Tue, Apr 14, 2015 at 12:47 PM, Milinda Pathirage wrote: > Hi Devs, > > Calcite dropped support for Java 1.6 in 1.1.0-incub

Re: Extra Systems and other extensions.

2015-04-14 Thread Dan
Thanks Jakob, I agree they'll be more maintained and tested if they're in the main repo so that's great. I'll sort out Jira's and get some patches of what we've got working now out for review. - Dan On 14 April 2015 at 19:56, Jakob Homan wrote: > Hey Dan- > I'd love for the Elastic Search st

Updating samza-sql branch to Java 1.7

2015-04-14 Thread Milinda Pathirage
Hi Devs, Calcite dropped support for Java 1.6 in 1.1.0-incubating. I want to use Calcite 1.2.0-incubating-SNAPSHOT in samza-sql branch. Is it okay to update samza-sql branch to Java 1.7? Thanks Milinda -- Milinda Pathirage PhD Student | Research Assistant School of Informatics and Computing |

Re: Extra Systems and other extensions.

2015-04-14 Thread Jakob Homan
Hey Dan- I'd love for the Elastic Search stuff to be added to the main code, as a separate module. Keeping these in the main source code keeps them more likely to be maintained and correct. The EvironemtnConfigRewriter can likely go in the same place as the ConfigRewriter interface, since it does

Extra Systems and other extensions.

2015-04-14 Thread Dan
Hey, At state.com we've started to write some generic extensions to Samza that we think would be more generally useful. We've got a ElasticsearchSystemProducer/Factory to output to an Elasticsearch index and EnvironmentConfigRewriter to modify config from environment variable. What's the best way

Re: Review Request 33170: Renamed samza-sql to samza-sql-core

2015-04-14 Thread Milinda Pathirage
> On April 14, 2015, 4:58 p.m., Yi Pan (Data Infrastructure) wrote: > > I assume that those files w/ Calcite dependencies moved to > > samza-sql-calcite later. Yes, I am going to move them to samza-sql-calcite later. - Milinda --- This

Re: Review Request 33170: Renamed samza-sql to samza-sql-core

2015-04-14 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33170/#review80043 --- Ship it! I assume that those files w/ Calcite dependencies moved to

Review Request 33170: Renamed samza-sql to samza-sql-core

2015-04-14 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33170/ --- Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). Bug