Re: Review Request 33488: SAMZA-657

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33488/#review82800 --- Overall looks good to me. We may need to re-base. checkstyle/impor

Re: Review Request 33735: RocksDB TTL support

> On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, lines > > 1009-1010 > > > > > > why do we remove the bloomfilter? > > Naveen Somasundaram wrote: >

Re: Review Request 33761: Fix SAMZA-658

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33761/#review82777 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 6, 2015,

Re: Review Request 33761: Fix SAMZA-658

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33761/ --- (Updated May 6, 2015, 11:38 p.m.) Review request for samza. Bugs: SAMZA-658

Re: Review Request 33453: SAMZA-557 Reuse local state in SamzaContainer on clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33453/#review82738 --- Overall looks good. Just one minor comment in the info log. samza-

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/#review82615 --- samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDb

Re: Review Request 33735: RocksDB TTL support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33735/ --- (Updated May 6, 2015, 8:55 p.m.) Review request for samza. Repository: samza

Re: Review Request 33735: RocksDB TTL support

> On May 1, 2015, 6:27 a.m., Yan Fang wrote: > > build.gradle, line 34 > > > > > > remember to remove the space. :) I have published it to maven, getting rid of this :) > On May 1, 2015, 6:27 a.m., Yan Fang wrote: >

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

> On May 6, 2015, 2:16 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java, > > line 40 > > > > > > Invalid parameter in doc comment. Thanks! Will fi

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

> On May 6, 2015, 2:11 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java, > > line 54 > > > > > > I'm not sure whether this is 100% correct

Re: Review Request 33453: SAMZA-557 Reuse local state in SamzaContainer on clean shutdown

> On May 6, 2015, 12:10 a.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > lines 481-486 > > > > > > 1. why does the changeLogSystemStreamPartition matter here? >

Re: Review Request 33453: SAMZA-557 Reuse local state in SamzaContainer on clean shutdown

> On May 6, 2015, 12:10 a.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > lines 481-486 > > > > > > 1. why does the changeLogSystemStreamPartition matter here? >

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82673 --- samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Fi

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82674 --- samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Me