Re: Review Request 33749: WIP: SAMZA-650 window store implementation

2015-05-07 Thread Yi Pan (Data Infrastructure)
On May 7, 2015, 2:22 p.m., Milinda Pathirage wrote: samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoiner.java, line 47 https://reviews.apache.org/r/33749/diff/2/?file=948513#file948513line47 I think that stream-to-stream joining is not practical for

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

2015-05-07 Thread Yi Pan (Data Infrastructure)
On May 7, 2015, 2:35 p.m., Milinda Pathirage wrote: samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowAutoOp.java, line 30 https://reviews.apache.org/r/33749/diff/2/?file=948519#file948519line30 Hi Yi, What is automated operator in this

Re: Review Request 33488: SAMZA-657

2015-05-07 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33488/#review82800 --- Overall looks good to me. We may need to re-base.

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

2015-05-07 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82821 ---

Re: Review Request 33761: Fix SAMZA-658

2015-05-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33761/ --- (Updated May 7, 2015, 9:11 p.m.) Review request for samza. Bugs: SAMZA-658

Re: Review Request 33749: WIP: SAMZA-650 window store implementation

2015-05-07 Thread Milinda Pathirage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33749/#review82824 ---

Re: Review Request 33761: Fix SAMZA-658

2015-05-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33761/ --- (Updated May 7, 2015, 5:07 p.m.) Review request for samza. Bugs: SAMZA-658