---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48215/#review136337
---
Ship it!
lgtm. Thanks for rebasing!
- Jagadish Venkatraman
O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48182/#review136335
---
Fix it, then Ship it!
samza-test/src/test/scala/org/apache/sam
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48213/#review136338
---
Fix it, then Ship it!
samza-hdfs/src/main/scala/org/apache/sam
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48182/#review135984
---
Fix it, then Ship it!
some nits.. otherwise, +1 !
samza-kv-ro
We use Samza RocksDB to keep track of our user event sessions. The task
periodically calls window() to update all sessions in the store and purge
all closed sessions.
We do all of this in the same iterator loop.
Here's how we are doing it:
public void window(MessageCollector collector, TaskCoor
Hi, David,
I would recommend to keep a separate table of closed sessions as a "queue",
ordered by the time the session is closed. And in your window method, just
create an iterator in the "queue" and only make progress toward the end of
the "queue", and do a point deletion in the sessionStore, whi
Hi, Yi,
Yes, the sessions are keyed by the sessionId.
In our case, iterating through all OPEN sessions is inevitable, since that
is precisely where we evaluate (base on timestamp) and close sessions. In
other words, the closed session queue you suggested cannot be constructed
without going throug
