[RESULT][DISCUSS] Moving Samza to Java 1.8 source compatibility.

2016-10-03 Thread Jacob Maes
I agree. This discussion was open for quite a while and we've seen no opposition. It's time to make the move. +1 (binding) x2 +1 (non-binding) x3 I've filed SAMZA-1031 to track the work for Samza 0.12. It should be relatively minor. -Jake On Fr

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-10-03 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/ --- (Updated Oct. 3, 2016, 4:04 p.m.) Review request for samza, Yi Pan (Data Infras

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-10-03 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/ --- (Updated Oct. 3, 2016, 4:54 p.m.) Review request for samza, Yi Pan (Data Infras

Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-03 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- Review request for samza. Repository: samza Description --- Every local

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-10-03 Thread Yi Pan (Data Infrastructure)
> On Sept. 29, 2016, 10:02 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala, > > line 197 > > > > > > Thinking of this more, I would prefer less

Re: [Discuss] Moving Samza to Java 1.8 source compatibility.

2016-10-03 Thread Boris Shkolnik
+1 for moving to 1.8. On Wed, Apr 27, 2016 at 6:27 PM, Jacob Maes wrote: > Hey everyone, > > I wanted to start a discussion to see what folks think about moving to Java > 1.8 source compatibility at some point after the 10.1 release. > > Java 8 has a number of nice features that can help us buil

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

2016-10-03 Thread Boris Shkolnik
+1 On Fri, Sep 30, 2016 at 1:39 PM, xinyu liu wrote: > Subject correction: [VOTE] Apache Samza 0.11.0 RC0. > > Thanks, > Xinyu > > On Fri, Sep 30, 2016 at 12:00 PM, xinyu liu wrote: > > > Hey all, > > > > This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to > > everyone who

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-03 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review151227 --- Overall, this is looking pretty good! Just some minor comments.

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

2016-10-03 Thread Jagadish Venkatraman
+1 from my side for the release (non-binding) On Mon, Oct 3, 2016 at 12:36 PM, Boris Shkolnik wrote: > +1 > > On Fri, Sep 30, 2016 at 1:39 PM, xinyu liu wrote: > > > Subject correction: [VOTE] Apache Samza 0.11.0 RC0. > > > > Thanks, > > Xinyu > > > > On Fri, Sep 30, 2016 at 12:00 PM, xinyu liu

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-03 Thread Yi Pan (Data Infrastructure)
> On Oct. 3, 2016, 11:11 p.m., Jagadish Venkatraman wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java, > > line 102 > > > > > > I thought the `Operators` class was maintai

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-03 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review151242 --- Fix it, then Ship it! LGTM There are still things that could b

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-03 Thread Yi Pan (Data Infrastructure)
> On Oct. 4, 2016, 12:10 a.m., Jake Maes wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java, > > line 505 > > > > > > Where is this used? I couldn't find it on any of the 3

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-03 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/ --- (Updated Oct. 4, 2016, 12:45 a.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-03 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review151273 --- Looks good. Just a couple things below. samza-core/src/main/scal