Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-20 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/#review153501 --- Ship it! LGTM, Thanks! - Jake Maes On Oct. 21, 2016, 12:45 a

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-20 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153478 --- Looks pretty good, few final comments. samza-core/src/main/java/

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-20 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/ --- (Updated Oct. 21, 2016, 12:45 a.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-20 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153468 --- samza-core/src/main/scala/org/apache/samza/config/StorageConfig.s

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-20 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153476 --- Ship it! - Boris Shkolnik On Oct. 19, 2016, 10:04 p.m., Shant

Re: Review Request 51634: SAMZA-1014: Add property to set YARN AM cpu cores

2016-10-20 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51634/#review153467 --- Ship it! Ship It! - Jagadish Venkatraman On Sept. 5, 2016, 5

Re: Review Request 53028: SAMZA-1040: Revert the ClassLoaderHelper change in SamzaContainer

2016-10-20 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53028/#review153466 --- Ship it! Ship It! - Boris Shkolnik On Oct. 19, 2016, 6:30 p.

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-20 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51633/#review153465 --- Ship it! - Jagadish Venkatraman On Oct. 7, 2016, 12:08 a.m.,

Re: Review Request 53000: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-20 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53000/#review153462 --- Ship it! Ship It! - Boris Shkolnik On Oct. 18, 2016, 10:17 p

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-20 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/ --- (Updated Oct. 20, 2016, 9:52 p.m.) Review request for samza. Repository: samz

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-20 Thread Shanthoosh Venkataraman
> On Oct. 17, 2016, 11:22 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitor.java, > > line 107 > > > > > > nit: I think this would read better if demorgans law were