Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-08 Thread Xinyu Liu
> On Nov. 2, 2016, 7:01 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/util/TimerClock.java, line 25 > > > > > > We have a HighResolutionClock that does this. I think you can use it > >

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-08 Thread Xinyu Liu
> On Nov. 2, 2016, 7:57 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 65 > > > > > > I don't think we should ever be creating a default new

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-08 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- (Updated Nov. 9, 2016, 2:14 a.m.) Review request for samza, Chris Pettitt,

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-11-08 Thread Shanthoosh Venkataraman
> On Nov. 3, 2016, 6:32 a.m., Prateek Maheshwari wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > > > > > What's the difference b/w containerId and containerName? > > Shanthoosh

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-11-08 Thread Shanthoosh Venkataraman
> On Nov. 4, 2016, 8:52 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 103 > > > > > > Why do we have preferredHost here? The terminology is really confusing.

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-11-08 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Nov. 9, 2016, 1:23 a.m.) Review request for samza. Repository:

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-08 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155380 --- docs/learn/documentation/versioned/rest/monitors.md (line 100)

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-08 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155372 --- docs/learn/documentation/versioned/rest/monitors.md (line 95)

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

2016-11-08 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/#review155377 --- Some minor code style/documentation related comments. One

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-08 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review155376 ---

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-08 Thread Prateek Maheshwari
> On Nov. 2, 2016, 12:57 p.m., Prateek Maheshwari wrote: > > Sorry for the late reply, didn't get an email notification for your replies. > On Nov. 2, 2016, 12:57 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 65 > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-08 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ --- (Updated Nov. 8, 2016, 11:13 p.m.) Review request for samza and Jake Maes.

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-08 Thread Shanthoosh Venkataraman
> On Nov. 5, 2016, 6:47 p.m., Jake Maes wrote: > > samza-core/src/main/scala/org/apache/samza/util/Util.scala, line 336 > > > > > > This edit looks like a mistake. > > > > Did this file need to be modified

Re: Using json serde with KeyValueStore

2016-11-08 Thread Raj raj
Thanks! It is working as expected. raj Thanks and Regards, Raj On Sat, Nov 5, 2016 at 11:24 PM, Jagadish Venkatraman wrote: > You can write a small test job and verify this! I believe the serde should > probably be able to serialize it correctly. > > You can define