Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
> On Nov. 9, 2016, 11:18 p.m., Prateek Maheshwari wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 55 > > > > > > What's the execution unit here? The samza-rest server? The

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
> On Nov. 9, 2016, 12:09 a.m., Jagadish Venkatraman wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 55 > > > > > > How exactly is this used when metrics are reported? > > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ --- (Updated Nov. 10, 2016, 1:04 a.m.) Review request for samza and Jake Maes.

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ --- (Updated Nov. 10, 2016, 12:04 a.m.) Review request for samza and Jake Maes.

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
> On Nov. 9, 2016, 11:18 p.m., Prateek Maheshwari wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 55 > > > > > > What's the execution unit here? The samza-rest server? The

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
> On Nov. 9, 2016, 12:09 a.m., Jagadish Venkatraman wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 55 > > > > > > How exactly is this used when metrics are reported? > > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Prateek Maheshwari
> On Nov. 5, 2016, 11:47 a.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 75 > > > > > > I don't think the MetricsConfig constructure takes a subset. > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Jagadish Venkatraman
> On Nov. 9, 2016, 12:09 a.m., Jagadish Venkatraman wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java, line 55 > > > > > > How exactly is this used when metrics are reported? > > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
> On Nov. 9, 2016, 12:09 a.m., Jagadish Venkatraman wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 65 > > > > > > Why is this taking in a concrete class -

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ --- (Updated Nov. 9, 2016, 10:50 p.m.) Review request for samza and Jake Maes.

Re: Review Request 53297: Initial version of adding metrics into samza rest.

2016-11-09 Thread Shanthoosh Venkataraman
> On Nov. 9, 2016, 12:31 a.m., Prateek Maheshwari wrote: > > samza-core/src/main/java/org/apache/samza/util/MetricsReporterLoader.java, > > line 36 > > > > > > Minor: private constructors for helper classes are

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-09 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review155478 --- Ship it! Looks pretty good, thanks!

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

2016-11-09 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- (Updated Nov. 9, 2016, 7:10 p.m.) Review request for samza, Chris Pettitt,