> On July 29, 2015, 8:42 a.m., Dan Harvey wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java,
> > line 116
> > <https://reviews.apache.org/r/36815/diff/6/?file=1024157#file1024157line116>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36905/#review93416
---
Lokks good.
- Dan Harvey
On July 29, 2015, 9:10 a.m., Aleksandar
iled to index message in ElasticSearch.", e);`
This would also be true for other log lines added.
One comment on the logging but I think this looks great otherwise.
- Dan Harvey
On July 29, 2015, 6:22 a.m., Roger Hoover wrote:
>
>
search/indexrequest/DefaultIndexRequestFactory.java
(line 92)
<https://reviews.apache.org/r/36815/#comment147604>
I know I set this line before but reading the elasticsearch docs they
recommend using `Requests.indexRequest(index).type(type)`
- Dan
---
Thanks,
Dan Harvey
---
Thanks,
Dan Harvey
've moved all config into ElasticsearchConfig and put
the factory code where it is used. It does seem cleaner now and easier to check
all the config.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://revi
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review80538
-----------
On May 1, 2015, 6:23 p.m., Dan Harvey wrote:
>
> ---
> This is an automatically genera
/DefaultIndexRequestFactoryTest.java
PRE-CREATION
settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
Diff: https://reviews.apache.org/r/33297/diff/
Testing
---
Thanks,
Dan Harvey
-------
On April 23, 2015, 6:18 p.m., Dan Harvey wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33297/
>
---
Thanks,
Dan Harvey
not sent until we invoke flush
> (Line 122). Is that right, Dan ?
>
> Dan Harvey wrote:
> Yes the send method puts the message onto a queue inside the
> BulkProcessor, if Elasticsearch fails to commit a document in a batch that
> will cause flush to raise an exception. There f
ly, visit:
https://reviews.apache.org/r/33297/#review81197
-------
On April 22, 2015, 5:12 p.m., Dan Harvey wrote:
>
> ---
> This is an automatically generated e-mail. To re
Elasticsearch documents can have version numbers that help with this.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review81184
----------
-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/IndexRequestFactory.java
PRE-CREATION
settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
Diff: https://reviews.apache.org/r/33297/diff/
Testing
---
Thanks,
Dan Harvey
: https://reviews.apache.org/r/33297/diff/
Testing
---
Thanks,
Dan Harvey
Yes added a singletion instance.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review80538
---
On April 17, 2015, 10:47 a.m., Dan
on-table for this.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33305/#review80843
---
On April 22, 2015, 3
PRE-CREATION
samza-core/src/test/java/org/apache/samza/config/EnvironmentConfigRewriterTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/33305/diff/
Testing
---
Thanks,
Dan Harvey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33305/#review80525
---
On April 17, 2015, 1:12 p.m., Dan Harvey wrote:
>
> --
-CREATION
Diff: https://reviews.apache.org/r/33305/diff/
Testing
---
Thanks,
Dan Harvey
/diff/
Testing
---
Thanks,
Dan Harvey
-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java
PRE-CREATION
settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
Diff: https://reviews.apache.org/r/33297/diff/
Testing
---
Thanks,
Dan Harvey
23 matches
Mail list logo
