Hi, Cameron,
That's generally the case. Thanks for Xinyu to bring this to
our attention! +1 to the stated guidelines.
-Yi
On Fri, May 17, 2019 at 11:10 AM Cameron Lee
wrote:
> Thanks Xinyu for starting this thread.
> I support the guidelines that you mentioned, with a couple clarifications
>
Thanks Xinyu for starting this thread.
I support the guidelines that you mentioned, with a couple clarifications
regarding "PR Review": If a Samza PR is authored by a committer, then
another second committer should provide an approval before that code is
merged, correct? Once the second committer
Hi, all,
I've seen different practices around how PRs are contributed, reviewed and
merged for Samza open source. I think it's time to bring up our committer
guide again to make sure we follow exactly the guidelines. It's also an
opportunity to talk about future improvement to the flow.
*PR