[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268902597 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268961813 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -594,7 +593,13 @@

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268959127 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-26 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268899597 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386258 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386607 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268384606 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386258 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386045 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386127 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386095 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386706 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268385471 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -711,4 +738,29 @@

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386149 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386358 ## File path: gradle/dependency-versions.gradle ## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2" joptSimpleVersion

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

2019-03-23 Thread GitBox
shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268385422 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12