GitHub user vjagadish opened a pull request:
https://github.com/apache/samza/pull/40
SAMZA-1077: Catch throwables in SamzaContainer
Here's the snippet from the startup sequence of the SamzaContainer.
SamzaContainer.scala
```
startProducers
startTask
startConsumers
startSecurityManger
info("Entering run loop.")
addShutdownHook
runLoop.run
} catch {
case e: Exception =>
error("Caught exception in process loop.", e)
throw e
} finally {
info("Shutting down.")
shutdownConsumers
shutdownTask
shutdownStores
```
In this case, the catch block should catch all Throwables instead of merely
catching Exceptions. This will cause errors like `NoSuchMethodErrors` to be
masked. Furthermore, the error can get lost completely if the finally block
throws an exception during any of the shutdown calls.
Catching all Throwables will prevent this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vjagadish1989/samza samza-1077
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit 6ad9bd90a74331397c45c91d20583e8a0a8b27cb
Author: vjagadish1989 <jvenk...@linkedin.com>
Date: 2017-01-06T19:27:26Z
SAMZA-1077: Catch throwables in SamzaContainer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
