Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review169231 --- Ship it! Ship It! - Xinyu Liu On Feb. 16, 2017, 6:26 a.m., S

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review169086 --- Please rebase this patch with master. samza-core/src/main/scala/

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review168665 --- Ship it! Looks good to me, thanks. samza-core/src/main/scala/

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On March 6, 2017, 2:33 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala > > Line 121 (original), 154 (patched) > > > > > > Should this be previousChan

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Feb. 23, 2017, 12:24 p.m., Prateek Maheshwari wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md > > Lines 119 (patched) > > > > > > The next two configs seem like JobsResource configs. If th

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review168041 --- samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordin

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review168039 --- samza-rest/src/main/java/org/apache/samza/rest/resources/TasksRes

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review166245 --- First pass, will look at JobCoordinator changes separately. docs

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Feb. 16, 2017, 6:26 a.m.) Review request for samza. Changes ---

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Nov. 3, 2016, 6:32 a.m., Prateek Maheshwari wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > > > > > What's the difference b/w containerId and containerName? > > Shanthoosh Venk

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Nov. 4, 2016, 8:52 p.m., Jagadish Venkatraman wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 103 > > > > > > Why do we have preferredHost here? The terminology is really confusing.

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Nov. 9, 2016, 1:23 a.m.) Review request for samza. Repository: samza

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review154972 --- Draft review so that I don't loose comments. Overall, it's hard t

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Nov. 2, 2016, 11:32 p.m., Prateek Maheshwari wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > > > > > What's the difference b/w containerId and containerName? > > Shanthoosh Ven

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review154832 --- samza-core/src/main/scala/org/apache/samza/util/Util.scala (line

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Nov. 3, 2016, 6:32 a.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > line 104 > > > > > > Don't think we need a Util method for a string concat.

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Nov. 4, 2016, 1:04 a.m.) Review request for samza. Repository: samza

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Nov. 3, 2016, 11:19 p.m.) Review request for samza. Repository: samz

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review154675 --- docs/learn/documentation/versioned/rest/resources/tasks.md (line

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 25, 2016, 9:06 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala, line 47 > > > > > > I would think the ideal place for this method will be in Util as > > opposed

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Nov. 3, 2016, 12:58 a.m.) Review request for samza. Repository: samz

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review153770 --- docs/learn/documentation/versioned/rest/resources/tasks.md (line

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review153819 --- I haven't read the previous comments. Hence, I may be repeating th

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 17, 2016, 9:38 p.m., Jake Maes wrote: > > One last thing that occurs to me. Since DefaultResourceFactory now includes both JobsResource and TasksResource, can you make sure the tutorial still works as written? We need every step to be exact s.t. users aren't confused. http://samza.a

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 24, 2016, 10 p.m.) Review request for samza. Repository: samza

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 17, 2016, 9:38 p.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 105 > > > > > > This comment still looks out of place. Maybe it should just be > > incorporated in

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152966 --- samza-core/src/main/scala/org/apache/samza/container/SamzaContain

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152928 --- docs/learn/documentation/versioned/rest/resources/tasks.md (line

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > > > > > What is the value of the container name? > > Shanthoosh Venkataraman wrote: > n

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > > > > > What is the value of the container name? > > Shanthoosh Venkataraman wrote: > n

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

- Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152418 --- On Oct. 13, 2016, 11:57 p.m., Shanthoosh Venkataram

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > > > > > What is the value of the container name? name of the samza container in which the t

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 13, 2016, 11:57 p.m.) Review request for samza. Repository: sam

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152418 --- docs/learn/documentation/versioned/rest/resources/tasks.md (line

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 12, 2016, 10:54 p.m.) Review request for samza. Repository: sam

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152412 --- samza-rest/src/main/java/org/apache/samza/rest/proxy/task/SamzaTa

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 10, 2016, 6:55 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/rest/proxy/task/SamzaTaskProxy.java, > > lines 128-130 > > > > > > This doesn't look right. > > > > It doesn't

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 10, 2016, 6:55 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/rest/proxy/job/SimpleYarnJobProxy.java, > > lines 48-51 > > > > > > What is the point of this refactor? > > > > I

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 10, 2016, 11:10 p.m.) Review request for samza. Repository: sam

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152002 --- This is a first pass and I was spot-checking. I'll need to do anot

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 8, 2016, 12:12 a.m.) Review request for samza. Repository: samz

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Sept. 23, 2016, 5:57 p.m.) Review request for samza. Repository: sam