Review Request 32407: SAMZA-571: add suppression interface for uncaught exceptions

2015-03-23 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32407/ --- Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, Navina Rames

Re: Review Request 32407: SAMZA-571: add suppression interface for uncaught exceptions

2015-03-23 Thread Chris Riccomini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32407/#review77470 --- * Nit: 2 space, not 4 space for indentation. * It's kind of odd to h

Re: Review Request 32407: SAMZA-571: add suppression interface for uncaught exceptions

2015-03-23 Thread Yi Pan (Data Infrastructure)
> On March 23, 2015, 11:29 p.m., Chris Riccomini wrote: > > * Nit: 2 space, not 4 space for indentation. > > * It's kind of odd to have exceptionHandler.maybeHandle { > > maybeHandle(coordinator, envelope, tryBlock = { ... I had a comment in the > > RB about consolidating this. > > * TestTaskIn

Re: Review Request 32407: SAMZA-571: add suppression interface for uncaught exceptions

2015-03-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32407/ --- (Updated March 25, 2015, 2:24 a.m.) Review request for samza, Yan Fang, Chinmay