On May 7, 2015, 2:22 p.m., Milinda Pathirage wrote:
samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoiner.java,
line 47
https://reviews.apache.org/r/33749/diff/2/?file=948513#file948513line47
I think that stream-to-stream joining is not practical for
On May 7, 2015, 2:35 p.m., Milinda Pathirage wrote:
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowAutoOp.java,
line 30
https://reviews.apache.org/r/33749/diff/2/?file=948519#file948519line30
Hi Yi, What is automated operator in this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82821
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82824
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82673
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33749/#review82674
---
On May 6, 2015, 2:16 p.m., Milinda Pathirage wrote:
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java,
line 40
https://reviews.apache.org/r/33749/diff/1-2/?file=947212#file947212line40
Invalid parameter in doc comment.
Thanks! Will fix.
- Yi
On May 6, 2015, 2:11 p.m., Milinda Pathirage wrote:
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java,
line 54
https://reviews.apache.org/r/33749/diff/2/?file=948526#file948526line54
I'm not sure whether this is 100% correct. For